From 74d3a6616bb8e96ff269ab07c7ffec1e83a815a5 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Mon, 24 Oct 2016 10:36:16 +0200 Subject: [PATCH 1/3] Upgrade to liquibase 3.5.3 Closes gh-7208 --- spring-boot-dependencies/pom.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spring-boot-dependencies/pom.xml b/spring-boot-dependencies/pom.xml index 29ae128776..004ccd68e5 100644 --- a/spring-boot-dependencies/pom.xml +++ b/spring-boot-dependencies/pom.xml @@ -122,7 +122,7 @@ 1.2 1.3.1 4.12 - 3.5.1 + 3.5.3 2.6.2 1.1.7 1.16.10 From 0b5fbbedf418be51333278a2d5d133c8a9b77283 Mon Sep 17 00:00:00 2001 From: Johnny Lim Date: Thu, 20 Oct 2016 11:07:21 +0900 Subject: [PATCH 2/3] Add a missing return This commit adds a missing`return` in `getDataSourceBeanDefinition()`. See gh-7193 --- .../autoconfigure/orm/jpa/TestDatabaseAutoConfiguration.java | 1 + 1 file changed, 1 insertion(+) diff --git a/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfiguration.java b/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfiguration.java index 560aa3a5da..33df6947e7 100644 --- a/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfiguration.java +++ b/spring-boot-test-autoconfigure/src/main/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfiguration.java @@ -118,6 +118,7 @@ public class TestDatabaseAutoConfiguration { if (ObjectUtils.isEmpty(beanNames)) { logger.warn("No DataSource beans found, " + "embedded version will not be used"); + return null; } if (beanNames.length == 1) { String beanName = beanNames[0]; From a03ce0a9d1e02dc9b0a1c43e81b286f90263ee93 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Mon, 24 Oct 2016 11:11:15 +0200 Subject: [PATCH 3/3] Polish contribution Add missing test Closes gh-7193 --- .../TestDatabaseAutoConfigurationTests.java | 63 +++++++++++++++++++ 1 file changed, 63 insertions(+) create mode 100644 spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfigurationTests.java diff --git a/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfigurationTests.java b/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfigurationTests.java new file mode 100644 index 0000000000..a27eef2f9f --- /dev/null +++ b/spring-boot-test-autoconfigure/src/test/java/org/springframework/boot/test/autoconfigure/orm/jpa/TestDatabaseAutoConfigurationTests.java @@ -0,0 +1,63 @@ +/* + * Copyright 2012-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.test.autoconfigure.orm.jpa; + +import javax.sql.DataSource; + +import org.junit.After; +import org.junit.Test; + +import org.springframework.boot.test.util.EnvironmentTestUtils; +import org.springframework.context.ConfigurableApplicationContext; +import org.springframework.context.annotation.AnnotationConfigApplicationContext; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for {@link TestDatabaseAutoConfiguration}. + * + * @author Stephane Nicoll + */ +public class TestDatabaseAutoConfigurationTests { + + private ConfigurableApplicationContext context; + + @After + public void closeContext() { + if (this.context != null) { + this.context.close(); + } + } + + @Test + public void replaceWithNoDataSourceAvailable() { + load(null); + assertThat(this.context.getBeansOfType(DataSource.class)).isEmpty(); + } + + public void load(Class config, String... environment) { + AnnotationConfigApplicationContext ctx = new AnnotationConfigApplicationContext(); + if (config != null) { + ctx.register(config); + } + ctx.register(TestDatabaseAutoConfiguration.class); + EnvironmentTestUtils.addEnvironment(ctx, environment); + ctx.refresh(); + this.context = ctx; + } + +}