From 653366d664423f7d9f76b6b42b07dc5c9dde0f3f Mon Sep 17 00:00:00 2001 From: Tommy Ludwig Date: Tue, 31 Jan 2017 20:50:35 +0900 Subject: [PATCH] Remove HikariCP-java6 dependency management Dependency management for the `HikariCP-java6` dependency is no longer needed since Java 6 is no longer supported by Spring Boot. The HikariDriverConfigurationFailureAnalyzer has been updated with the current message thrown by HikariCP in this failure scenario. Closes gh-8147 --- spring-boot-actuator/pom.xml | 2 +- spring-boot-autoconfigure/pom.xml | 2 +- .../jdbc/HikariDriverConfigurationFailureAnalyzer.java | 4 ++-- spring-boot-dependencies/pom.xml | 6 ------ 4 files changed, 4 insertions(+), 10 deletions(-) diff --git a/spring-boot-actuator/pom.xml b/spring-boot-actuator/pom.xml index 650d0a7d3b..3eb06c8c7a 100644 --- a/spring-boot-actuator/pom.xml +++ b/spring-boot-actuator/pom.xml @@ -256,7 +256,7 @@ com.zaxxer - HikariCP-java6 + HikariCP true diff --git a/spring-boot-autoconfigure/pom.xml b/spring-boot-autoconfigure/pom.xml index 7c022f5a7c..45ef4defb2 100755 --- a/spring-boot-autoconfigure/pom.xml +++ b/spring-boot-autoconfigure/pom.xml @@ -241,7 +241,7 @@ com.zaxxer - HikariCP-java6 + HikariCP true diff --git a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/HikariDriverConfigurationFailureAnalyzer.java b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/HikariDriverConfigurationFailureAnalyzer.java index dc552ab1c8..eb8e819944 100644 --- a/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/HikariDriverConfigurationFailureAnalyzer.java +++ b/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/HikariDriverConfigurationFailureAnalyzer.java @@ -28,8 +28,8 @@ import org.springframework.boot.diagnostics.FailureAnalysis; class HikariDriverConfigurationFailureAnalyzer extends AbstractFailureAnalyzer { - private static final String EXPECTED_MESSAGE = "both driverClassName and " - + "dataSourceClassName are specified, one or the other should be used"; + private static final String EXPECTED_MESSAGE = "cannot use driverClassName and " + + "dataSourceClassName together."; @Override protected FailureAnalysis analyze(Throwable rootFailure, diff --git a/spring-boot-dependencies/pom.xml b/spring-boot-dependencies/pom.xml index 43ced44ab0..a932f5d35d 100644 --- a/spring-boot-dependencies/pom.xml +++ b/spring-boot-dependencies/pom.xml @@ -87,7 +87,6 @@ 5.2.5.Final 5.3.4.Final 2.5.1 - 2.3.13 2.3.3 2.21 4.1.2 @@ -743,11 +742,6 @@ HikariCP ${hikaricp.version} - - com.zaxxer - HikariCP-java6 - ${hikaricp-java6.version} - commons-beanutils commons-beanutils