From 77f1da871fde6d475fe98fbbd03f9a3573b06fb8 Mon Sep 17 00:00:00 2001 From: Andy Wilkinson Date: Wed, 5 Oct 2016 14:54:23 +0100 Subject: [PATCH] Add a second, portal-compatible ID to the Gradle plugin To be compatible with Gradle's plugin portal, plugins must have an ID that uses a reverse domain name. This means that spring-boot is not compatible. This commit introduces a new ID, org.springframework.boot, and deprecates the old ID. Closes gh-6997 --- .../src/main/asciidoc/build-tool-plugins.adoc | 2 +- .../src/main/asciidoc/deployment.adoc | 2 +- .../src/main/asciidoc/getting-started.adoc | 2 +- .../src/main/asciidoc/using-spring-boot.adoc | 2 +- .../boot/gradle/DeprecatedPluginTests.java | 50 +++++++++++++++++++ .../resources/boot-run-resources/build.gradle | 2 +- .../resources/classifier-extension.gradle | 2 +- .../src/test/resources/classifier.gradle | 2 +- .../test/resources/deprecated-plugin.gradle | 26 ++++++++++ .../resources/executable-jar/build.gradle | 2 +- .../src/test/resources/flatdir.gradle | 2 +- .../src/test/resources/install-app.gradle | 2 +- .../src/test/resources/installer.gradle | 4 +- .../src/test/resources/main-class.gradle | 2 +- .../mixed-version-repackaging.gradle | 2 +- .../build.gradle | 2 +- .../build.gradle | 2 +- .../build.gradle | 2 +- .../src/test/resources/nojar.gradle | 2 +- .../src/test/resources/repackage.gradle | 2 +- .../spring-loaded-jvm-args/build.gradle | 2 +- .../spring-loaded-old-gradle/build.gradle | 2 +- .../resources/starter-dependencies.gradle | 2 +- .../src/test/resources/war-packaging.gradle | 4 +- .../spring-boot-sample-actuator/build.gradle | 2 +- .../spring-boot-sample-data-neo4j/pom.xml | 11 +++- .../spring-boot-sample-logback/build.gradle | 2 +- .../spring-boot-sample-profile/build.gradle | 2 +- .../spring-boot-sample-simple/build.gradle | 2 +- .../build.gradle | 2 +- .../spring-boot-sample-web-ui/build.gradle | 2 +- .../gradle/SpringBootPluginExtension.java | 2 +- .../plugin/DeprecatedSpringBootPlugin.java | 43 ++++++++++++++++ .../org.springframework.boot.properties | 1 + .../gradle-plugins/spring-boot.properties | 2 +- 35 files changed, 162 insertions(+), 33 deletions(-) create mode 100644 spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/DeprecatedPluginTests.java create mode 100644 spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/deprecated-plugin.gradle create mode 100644 spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/DeprecatedSpringBootPlugin.java create mode 100644 spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/org.springframework.boot.properties diff --git a/spring-boot-docs/src/main/asciidoc/build-tool-plugins.adoc b/spring-boot-docs/src/main/asciidoc/build-tool-plugins.adoc index c10945ba47..7321e189e3 100644 --- a/spring-boot-docs/src/main/asciidoc/build-tool-plugins.adoc +++ b/spring-boot-docs/src/main/asciidoc/build-tool-plugins.adoc @@ -182,7 +182,7 @@ the `spring-boot` plugin: classpath("org.springframework.boot:spring-boot-gradle-plugin:{spring-boot-version}") } } - apply plugin: 'spring-boot' + apply plugin: 'org.springframework.boot' ---- If you are using a milestone or snapshot release you will also need to add appropriate diff --git a/spring-boot-docs/src/main/asciidoc/deployment.adoc b/spring-boot-docs/src/main/asciidoc/deployment.adoc index ff6a2a13d9..834147ef3f 100644 --- a/spring-boot-docs/src/main/asciidoc/deployment.adoc +++ b/spring-boot-docs/src/main/asciidoc/deployment.adoc @@ -387,7 +387,7 @@ With Gradle, the equivalent configuration would be: [source,groovy,indent=0,subs="verbatim,quotes,attributes"] ---- - apply plugin: 'spring-boot' + apply plugin: 'org.springframework.boot' springBoot { executable = true diff --git a/spring-boot-docs/src/main/asciidoc/getting-started.adoc b/spring-boot-docs/src/main/asciidoc/getting-started.adoc index 14c9c7f849..29f48f7a0f 100644 --- a/spring-boot-docs/src/main/asciidoc/getting-started.adoc +++ b/spring-boot-docs/src/main/asciidoc/getting-started.adoc @@ -240,7 +240,7 @@ endif::release[] } apply plugin: 'java' - apply plugin: 'spring-boot' + apply plugin: 'org.springframework.boot' jar { baseName = 'myproject' diff --git a/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc b/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc index 070ad9cb29..de0967e153 100644 --- a/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc +++ b/spring-boot-docs/src/main/asciidoc/using-spring-boot.adoc @@ -257,7 +257,7 @@ endif::[] } apply plugin: 'java' - apply plugin: 'spring-boot' + apply plugin: 'org.springframework.boot' repositories { ifeval::["{spring-boot-repo}" != "release"] diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/DeprecatedPluginTests.java b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/DeprecatedPluginTests.java new file mode 100644 index 0000000000..41b41d0792 --- /dev/null +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/java/org/springframework/boot/gradle/DeprecatedPluginTests.java @@ -0,0 +1,50 @@ +/* + * Copyright 2012-2016 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.gradle; + +import org.gradle.tooling.ProjectConnection; +import org.junit.Rule; +import org.junit.Test; + +import org.springframework.boot.test.rule.OutputCapture; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for using the old, deprecated plugin ID. + * + * @author Andy Wilkinson + */ +public class DeprecatedPluginTests { + + private ProjectConnection project; + + private static final String BOOT_VERSION = Versions.getBootVersion(); + + @Rule + public OutputCapture output = new OutputCapture(); + + @Test + public void deprecatedIdWorksAndLogsAWarning() throws Exception { + this.project = new ProjectCreator().createProject("deprecated-plugin"); + this.project.newBuild().forTasks("build") + .withArguments("-PbootVersion=" + BOOT_VERSION, "--stacktrace").run(); + assertThat(this.output.toString()) + .contains("The plugin id 'spring-boot' is deprecated"); + } + +} diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/boot-run-resources/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/boot-run-resources/build.gradle index b5b1eaa5e2..c8a854743c 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/boot-run-resources/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/boot-run-resources/build.gradle @@ -8,7 +8,7 @@ buildscript { } apply plugin: 'java' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' repositories { mavenLocal() diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier-extension.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier-extension.gradle index da980ba30f..302cb56e61 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier-extension.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier-extension.gradle @@ -9,7 +9,7 @@ buildscript { apply plugin: 'java' apply plugin: 'maven' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' jar { baseName = 'classifier-extension' diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier.gradle index e77c5dab3a..abf9c95bfa 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/classifier.gradle @@ -9,7 +9,7 @@ buildscript { apply plugin: 'java' apply plugin: 'maven' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' jar { baseName = 'classifier' diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/deprecated-plugin.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/deprecated-plugin.gradle new file mode 100644 index 0000000000..a3cd6b4f37 --- /dev/null +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/deprecated-plugin.gradle @@ -0,0 +1,26 @@ +buildscript { + repositories { + mavenLocal() + } + dependencies { + classpath("org.springframework.boot:spring-boot-gradle-plugin:${project.bootVersion}") + } +} + +apply plugin: 'spring-boot' + +group = 'deprecated-plugin' +version = '0.0.0' + +repositories { + mavenLocal() + mavenCentral() +} + +springBoot { + mainClass 'com.example.Main' +} + +dependencies { + compile 'org.springframework.boot:spring-boot-starter' +} \ No newline at end of file diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/executable-jar/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/executable-jar/build.gradle index 14444a71e7..25986b5968 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/executable-jar/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/executable-jar/build.gradle @@ -12,7 +12,7 @@ repositories { mavenCentral() } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' apply plugin: 'java' dependencies { diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/flatdir.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/flatdir.gradle index fdb8314972..1617ae2a87 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/flatdir.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/flatdir.gradle @@ -7,7 +7,7 @@ buildscript { } } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' group = 'flatdir' version = '0.0.0' diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/install-app.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/install-app.gradle index 88a966b098..89744abfe3 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/install-app.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/install-app.gradle @@ -9,7 +9,7 @@ buildscript { apply plugin: 'java' apply plugin: 'maven' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' apply plugin: 'application' group = 'installer' diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/installer.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/installer.gradle index bc24c4b133..db0f6c0fbd 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/installer.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/installer.gradle @@ -9,7 +9,7 @@ buildscript { apply plugin: 'java' apply plugin: 'maven' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' group = 'installer' version = '0.0.0' @@ -17,7 +17,7 @@ version = '0.0.0' install { repositories.mavenInstaller { pom.project { - parent { + parent { groupId 'org.springframework.boot' artifactId 'spring-boot-starter-parent' version "${project.bootVersion}" diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/main-class.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/main-class.gradle index 982cd946d1..7688b62d8a 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/main-class.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/main-class.gradle @@ -9,7 +9,7 @@ buildscript { apply plugin: 'java' apply plugin: 'maven' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' group = 'installer' version = '0.0.0' diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/mixed-version-repackaging.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/mixed-version-repackaging.gradle index 9fb72c1c14..9b2ef45dfa 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/mixed-version-repackaging.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/mixed-version-repackaging.gradle @@ -13,7 +13,7 @@ repositories { mavenCentral() } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' apply plugin: 'java' dependencies { diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-common-file-dependency/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-common-file-dependency/build.gradle index 887ea90698..9285bfc05b 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-common-file-dependency/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-common-file-dependency/build.gradle @@ -15,7 +15,7 @@ subprojects { } } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' repositories { mavenLocal() diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-runtime-project-dependency/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-runtime-project-dependency/build.gradle index fe60f4f57e..e33e5c4baf 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-runtime-project-dependency/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-runtime-project-dependency/build.gradle @@ -8,7 +8,7 @@ buildscript { } project(':projectA') { - apply plugin: 'spring-boot' + apply plugin: 'org.springframework.boot' repositories { mavenLocal() } diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-transitive-file-dependency/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-transitive-file-dependency/build.gradle index 87ef48932c..7b1e7ab95b 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-transitive-file-dependency/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/multi-project-transitive-file-dependency/build.gradle @@ -8,7 +8,7 @@ buildscript { } project('main') { - apply plugin: 'spring-boot' + apply plugin: 'org.springframework.boot' apply plugin: 'java' repositories { diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/nojar.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/nojar.gradle index 045a589f75..b2e1872648 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/nojar.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/nojar.gradle @@ -7,7 +7,7 @@ buildscript { } } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' group = 'nojar' version = '0.0.0' diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/repackage.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/repackage.gradle index 9a7f4d255b..455bb0e443 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/repackage.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/repackage.gradle @@ -12,7 +12,7 @@ repositories { mavenCentral() } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' apply plugin: 'java' dependencies { diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-jvm-args/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-jvm-args/build.gradle index 7cc675f6ab..92e4dd9d27 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-jvm-args/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-jvm-args/build.gradle @@ -10,7 +10,7 @@ buildscript { } apply plugin: 'java' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' repositories { mavenLocal() diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-old-gradle/build.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-old-gradle/build.gradle index 70d15523ad..83ca8f70a2 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-old-gradle/build.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/spring-loaded-old-gradle/build.gradle @@ -10,7 +10,7 @@ buildscript { } apply plugin: 'java' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' repositories { mavenLocal() diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/starter-dependencies.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/starter-dependencies.gradle index 36e51e750b..f00c9d2de8 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/starter-dependencies.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/starter-dependencies.gradle @@ -22,7 +22,7 @@ dependencies { springBootStarter "org.springframework.boot:${project.starter}:${project.bootVersion}" } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' task checkCommonsLogging { doFirst { diff --git a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/war-packaging.gradle b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/war-packaging.gradle index 9ff8591d00..af52898c6e 100644 --- a/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/war-packaging.gradle +++ b/spring-boot-integration-tests/spring-boot-gradle-tests/src/test/resources/war-packaging.gradle @@ -14,10 +14,10 @@ repositories { mavenCentral() } -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' apply plugin: 'war' -dependencies { +dependencies { compile 'org.springframework.boot:spring-boot-starter-freemarker' providedRuntime "org.springframework.boot:spring-boot-starter-$servletContainer" } diff --git a/spring-boot-samples/spring-boot-sample-actuator/build.gradle b/spring-boot-samples/spring-boot-sample-actuator/build.gradle index da7f05f5fe..4287ea6d65 100644 --- a/spring-boot-samples/spring-boot-sample-actuator/build.gradle +++ b/spring-boot-samples/spring-boot-sample-actuator/build.gradle @@ -18,7 +18,7 @@ buildscript { apply plugin: 'java' apply plugin: 'eclipse' apply plugin: 'idea' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' jar { baseName = 'spring-boot-sample-actuator' diff --git a/spring-boot-samples/spring-boot-sample-data-neo4j/pom.xml b/spring-boot-samples/spring-boot-sample-data-neo4j/pom.xml index c094bf8037..74dc2f5632 100644 --- a/spring-boot-samples/spring-boot-sample-data-neo4j/pom.xml +++ b/spring-boot-samples/spring-boot-sample-data-neo4j/pom.xml @@ -23,7 +23,16 @@ org.springframework.boot spring-boot-starter-data-neo4j - + org.springframework.boot spring-boot-starter-test diff --git a/spring-boot-samples/spring-boot-sample-logback/build.gradle b/spring-boot-samples/spring-boot-sample-logback/build.gradle index 8f25b30d3b..a10b5a6dca 100644 --- a/spring-boot-samples/spring-boot-sample-logback/build.gradle +++ b/spring-boot-samples/spring-boot-sample-logback/build.gradle @@ -18,7 +18,7 @@ buildscript { apply plugin: 'java' apply plugin: 'eclipse' apply plugin: 'idea' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' jar { baseName = 'spring-boot-sample-simple' diff --git a/spring-boot-samples/spring-boot-sample-profile/build.gradle b/spring-boot-samples/spring-boot-sample-profile/build.gradle index b397fbd4ee..e2ce5d290a 100644 --- a/spring-boot-samples/spring-boot-sample-profile/build.gradle +++ b/spring-boot-samples/spring-boot-sample-profile/build.gradle @@ -18,7 +18,7 @@ buildscript { apply plugin: 'java' apply plugin: 'eclipse' apply plugin: 'idea' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' jar { baseName = 'spring-boot-sample-profile' diff --git a/spring-boot-samples/spring-boot-sample-simple/build.gradle b/spring-boot-samples/spring-boot-sample-simple/build.gradle index 8f25b30d3b..a10b5a6dca 100644 --- a/spring-boot-samples/spring-boot-sample-simple/build.gradle +++ b/spring-boot-samples/spring-boot-sample-simple/build.gradle @@ -18,7 +18,7 @@ buildscript { apply plugin: 'java' apply plugin: 'eclipse' apply plugin: 'idea' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' jar { baseName = 'spring-boot-sample-simple' diff --git a/spring-boot-samples/spring-boot-sample-web-static/build.gradle b/spring-boot-samples/spring-boot-sample-web-static/build.gradle index d541a05324..f04ba19624 100644 --- a/spring-boot-samples/spring-boot-sample-web-static/build.gradle +++ b/spring-boot-samples/spring-boot-sample-web-static/build.gradle @@ -19,7 +19,7 @@ buildscript { apply plugin: 'java' apply plugin: 'eclipse-wtp' apply plugin: 'idea' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' apply plugin: 'war' war { diff --git a/spring-boot-samples/spring-boot-sample-web-ui/build.gradle b/spring-boot-samples/spring-boot-sample-web-ui/build.gradle index b6b106f343..b355175c37 100644 --- a/spring-boot-samples/spring-boot-sample-web-ui/build.gradle +++ b/spring-boot-samples/spring-boot-sample-web-ui/build.gradle @@ -21,7 +21,7 @@ buildscript { apply plugin: 'java' apply plugin: 'eclipse' apply plugin: 'idea' -apply plugin: 'spring-boot' +apply plugin: 'org.springframework.boot' springBoot { classifier = 'exec' diff --git a/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/SpringBootPluginExtension.java b/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/SpringBootPluginExtension.java index a852dfff24..e4244b22b4 100644 --- a/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/SpringBootPluginExtension.java +++ b/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/SpringBootPluginExtension.java @@ -34,7 +34,7 @@ import org.springframework.boot.loader.tools.Layouts; * two of them. E.g. * *
- *     apply plugin: "spring-boot"
+ *     apply plugin: 'org.springframework.boot'
  *     springBoot {
  *         mainClass = 'org.demo.Application'
  *         layout = 'ZIP'
diff --git a/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/DeprecatedSpringBootPlugin.java b/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/DeprecatedSpringBootPlugin.java
new file mode 100644
index 0000000000..65dc7d2697
--- /dev/null
+++ b/spring-boot-tools/spring-boot-gradle-plugin/src/main/java/org/springframework/boot/gradle/plugin/DeprecatedSpringBootPlugin.java
@@ -0,0 +1,43 @@
+/*
+ * Copyright 2012-2016 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.springframework.boot.gradle.plugin;
+
+import org.gradle.api.Project;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * {@link SpringBootPlugin} subclass that outputs a deprecation warning to direct people
+ * to use the new Gradle Plugin Portal-compatible ID {@code org.springframework.boot}.
+ *
+ * @author Andy Wilkinson
+ * @deprecated since 1.4.2 in favor of {@link SpringBootPlugin}
+ */
+@Deprecated
+public class DeprecatedSpringBootPlugin extends SpringBootPlugin {
+
+	private static final Logger logger = LoggerFactory
+			.getLogger(DeprecatedSpringBootPlugin.class);
+
+	@Override
+	public void apply(Project project) {
+		logger.warn("The plugin id 'spring-boot' is deprecated. Please use "
+				+ "'org.springframework.boot' instead.");
+		super.apply(project);
+	}
+
+}
diff --git a/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/org.springframework.boot.properties b/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/org.springframework.boot.properties
new file mode 100644
index 0000000000..730938f5c3
--- /dev/null
+++ b/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/org.springframework.boot.properties
@@ -0,0 +1 @@
+implementation-class=org.springframework.boot.gradle.plugin.SpringBootPlugin
diff --git a/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/spring-boot.properties b/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/spring-boot.properties
index 730938f5c3..dc82bb3bef 100644
--- a/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/spring-boot.properties
+++ b/spring-boot-tools/spring-boot-gradle-plugin/src/main/resources/META-INF/gradle-plugins/spring-boot.properties
@@ -1 +1 @@
-implementation-class=org.springframework.boot.gradle.plugin.SpringBootPlugin
+implementation-class=org.springframework.boot.gradle.plugin.DeprecatedSpringBootPlugin