Merge pull request #35455 from be-hase

* pr/35455:
  Polish "Fix invalid Zipkin Reporter back-off behavior"
  Fix invalid Zipkin Reporter back-off behavior

Closes gh-35455
pull/35611/head
Phillip Webb 2 years ago
commit d6a1a3d71a

@ -118,7 +118,7 @@ class ZipkinConfigurations {
static class ReporterConfiguration {
@Bean
@ConditionalOnMissingBean
@ConditionalOnMissingBean(Reporter.class)
@ConditionalOnBean(Sender.class)
AsyncReporter<Span> spanReporter(Sender sender, BytesEncoder<Span> encoder) {
return AsyncReporter.builder(sender).build(encoder);

@ -56,10 +56,11 @@ class ZipkinConfigurationsReporterConfigurationTests {
@Test
void shouldBackOffOnCustomBeans() {
this.contextRunner.withUserConfiguration(CustomConfiguration.class).run((context) -> {
assertThat(context).hasBean("customReporter");
assertThat(context).hasSingleBean(Reporter.class);
});
this.contextRunner.withUserConfiguration(SenderConfiguration.class, CustomConfiguration.class)
.run((context) -> {
assertThat(context).hasBean("customReporter");
assertThat(context).hasSingleBean(Reporter.class);
});
}
@Configuration(proxyBeanMethods = false)

Loading…
Cancel
Save