From edf4045c3b29ae15ecb967379a83ff6e448af0e5 Mon Sep 17 00:00:00 2001 From: Stephane Nicoll Date: Mon, 15 Oct 2018 17:55:07 +0200 Subject: [PATCH] Add missing tests for Kairos config adapter Closes gh-14821 --- .../KairosPropertiesConfigAdapterTests.java | 66 +++++++++++++++ ...pRegistryPropertiesConfigAdapterTests.java | 81 +++++++++++++++++++ 2 files changed, 147 insertions(+) create mode 100644 spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/kairos/KairosPropertiesConfigAdapterTests.java create mode 100644 spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/properties/StepRegistryPropertiesConfigAdapterTests.java diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/kairos/KairosPropertiesConfigAdapterTests.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/kairos/KairosPropertiesConfigAdapterTests.java new file mode 100644 index 0000000000..aeb97a97b8 --- /dev/null +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/kairos/KairosPropertiesConfigAdapterTests.java @@ -0,0 +1,66 @@ +/* + * Copyright 2012-2018 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.actuate.autoconfigure.metrics.export.kairos; + +import org.junit.Test; + +import org.springframework.boot.actuate.autoconfigure.metrics.export.properties.StepRegistryPropertiesConfigAdapterTests; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for {@link KairosPropertiesConfigAdapter}. + * + * @author Stephane Nicoll + */ +public class KairosPropertiesConfigAdapterTests extends + StepRegistryPropertiesConfigAdapterTests { + + @Override + protected KairosProperties createProperties() { + return new KairosProperties(); + } + + @Override + protected KairosPropertiesConfigAdapter createConfigAdapter( + KairosProperties properties) { + return new KairosPropertiesConfigAdapter(properties); + } + + @Test + public void whenPropertiesUrisIsSetAdapterUriReturnsIt() { + KairosProperties properties = createProperties(); + properties.setUri("https://kairos.example.com:8080/api/v1/datapoints"); + assertThat(createConfigAdapter(properties).uri()) + .isEqualTo("https://kairos.example.com:8080/api/v1/datapoints"); + } + + @Test + public void whenPropertiesUserNameIsSetAdapterUserNameReturnsIt() { + KairosProperties properties = createProperties(); + properties.setUserName("alice"); + assertThat(createConfigAdapter(properties).userName()).isEqualTo("alice"); + } + + @Test + public void whenPropertiesPasswordIsSetAdapterPasswordReturnsIt() { + KairosProperties properties = createProperties(); + properties.setPassword("secret"); + assertThat(createConfigAdapter(properties).password()).isEqualTo("secret"); + } + +} diff --git a/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/properties/StepRegistryPropertiesConfigAdapterTests.java b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/properties/StepRegistryPropertiesConfigAdapterTests.java new file mode 100644 index 0000000000..9d26523817 --- /dev/null +++ b/spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/metrics/export/properties/StepRegistryPropertiesConfigAdapterTests.java @@ -0,0 +1,81 @@ +/* + * Copyright 2012-2018 the original author or authors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.springframework.boot.actuate.autoconfigure.metrics.export.properties; + +import java.time.Duration; + +import org.junit.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Base test for {@link StepRegistryPropertiesConfigAdapter} implementations. + * + * @author Stephane Nicoll + */ +public abstract class StepRegistryPropertiesConfigAdapterTests

> { + + protected abstract P createProperties(); + + protected abstract A createConfigAdapter(P properties); + + @Test + public void whenPropertiesStepIsSetAdapterStepReturnsIt() { + P properties = createProperties(); + properties.setStep(Duration.ofSeconds(42)); + assertThat(createConfigAdapter(properties).step()) + .isEqualTo(Duration.ofSeconds(42)); + } + + @Test + public void whenPropertiesEnabledIsSetAdapterEnabledReturnsIt() { + P properties = createProperties(); + properties.setEnabled(false); + assertThat(createConfigAdapter(properties).enabled()).isFalse(); + } + + @Test + public void whenPropertiesConnectTimeoutIsSetAdapterConnectTimeoutReturnsIt() { + P properties = createProperties(); + properties.setConnectTimeout(Duration.ofMinutes(42)); + assertThat(createConfigAdapter(properties).connectTimeout()) + .isEqualTo(Duration.ofMinutes(42)); + } + + @Test + public void whenPropertiesReadTimeoutIsSetAdapterReadTimeoutReturnsIt() { + P properties = createProperties(); + properties.setReadTimeout(Duration.ofMillis(42)); + assertThat(createConfigAdapter(properties).readTimeout()) + .isEqualTo(Duration.ofMillis(42)); + } + + @Test + public void whenPropertiesNumThreadsIsSetAdapterNumThreadsReturnsIt() { + P properties = createProperties(); + properties.setNumThreads(42); + assertThat(createConfigAdapter(properties).numThreads()).isEqualTo(42); + } + + @Test + public void whenPropertiesBatchSizeIsSetAdapterBatchSizeReturnsIt() { + P properties = createProperties(); + properties.setBatchSize(10042); + assertThat(createConfigAdapter(properties).batchSize()).isEqualTo(10042); + } + +}