Commit Graph

1014 Commits (0fd5ef16323adbace20e7712b5b61120ce302279)

Author SHA1 Message Date
Phillip Webb 64930d4e5b Polish caught exception names
Prefer `ex` over `e`.
7 years ago
Phillip Webb 3ee777e142 Polish ternary expressions
Consistently format ternary expressions and always favor `!=` as the
the check.
7 years ago
Stephane Nicoll dd3f57d816 Avoid potentially mutating item metadata collection
Closes gh-13027
7 years ago
Spring Buildmaster c10aad165f Next Development Version 7 years ago
Spring Buildmaster ade4760842 Next Development Version 7 years ago
Phillip Webb 624a5f8260 Apply URL decoding for nested jar entry names
Update `JarURLConnection` to apply URL decoding to nested jar entry
names.

Fixes gh-12765
7 years ago
Stephane Nicoll 610ffed938 Merge pull request #12629 from oflebbe:1.5.x
* pr/12629:
  Polish "Use secure connection to repositories"
  Use secure connection to repositories
7 years ago
Stephane Nicoll ade6d86b65 Polish "Use secure connection to repositories"
Closes gh-12629
7 years ago
dreis2211 efc9dcc22b Fix ModifiedClassPathRunner tests if run via IDEA
IntelliJ can shorten the classpath to a single classpath.jar in order to
circumvent errors originating from a too long classpath. This breaks the
filtering inside ModifiedClassPathRunner as the classpath contains only a
single jar to match against. This can be fixed by applying a similar
mechanism already provided for Surefire manifest-only booter JARs, which
extracts the real classpath from the JAR's Manifest file.

See gh-12535
7 years ago
Phillip Webb a8f366a554 Fix copyright header for edited files 7 years ago
Phillip Webb e975dbe3f0 Only use jar shortcut for matching URLs
Update JAR `Handler` logic so that the existing `jarFile` is only used
if the requested URL starts with the same path. Prior to this commit it
was possible to construct a URL with another URL as context. This could
mean that the `handler` was shared and the already resolved `jarFile`
contained in the handler wasn't necessarily suitable.

Fixes gh-12483
7 years ago
Andy Wilkinson eee891dbc8 Decode file: URLs passed into PropertiesLauncher via loader.path
Closes gh-12325
7 years ago
Stephane Nicoll b4a7e1d64b Use toLowerCase() and toUpperCase() with Locale.ENGLISH
This commit updates all `toLowerCase()` and `toUpperCase` invocations to
use the variant that takes a `Locale` to avoid locale-specific side
effect.

Closes gh-12213
7 years ago
Andy Wilkinson 915eaf3447 Polish 7 years ago
Andy Wilkinson 746cc0f70b Make JarFile.size() return the number of entries in the jar
Closes gh-12195
7 years ago
Andy Wilkinson d59000ceb1 Change ownership when log file is created by launch script
Closes gh-11951
7 years ago
Phillip Webb 798522d890 Format with Eclipse Oxygen SR2 7 years ago
Spring Buildmaster 6414b42335 Next Development Version 7 years ago
Phillip Webb 9b8cb9a463 Protect against symlink attacks
Update embedded launch script to no longer change ownership of files
or folders that already exist.

Fixes gh-11397
7 years ago
Phillip Webb 61f7bd8576 Polish 7 years ago
Stephane Nicoll f86b44f2ec Reduce StringBuilder creation in TypeExtractor.visitDeclared()
Closes gh-11845
7 years ago
Phillip Webb 8e783cdae9 Polish 7 years ago
Stephane Nicoll 71ab5dd748 Restore proper handling of array types
Closes gh-11512
7 years ago
Stephane Nicoll 927c2cacfa Rework type generation algorithm
The initial solution to gh-11512 was still using a plain `toString` that
could potentially break with a JDK upgrade. Turns out that JDK9 actually
uses the same type for AnnotatedType and ClassType so the trick of using
a visitor doesn't work anymore.

Retrospectively, it is quite easy to generate the full type once we have
the DeclaredType as we already have some logic to get the qualified,
that is raw, type and we have access to the type parameters.

This commit still uses a `toString` to generate the representation of
the type parameters but this looks much safer than trying to redo what
such a simple `toString` should do. Also, the additional metadata that
we could get on an ExecutableElement does not apply to them.

Closes gh-11512
7 years ago
Stephane Nicoll d8b1f1692a Fix type detection with annotated getter
This commit makes sure that the `type` of a property is generated
property if the getter of the property is annotated. Previously, a type
implementation may expose the annotation information.

Closes gh-11512
7 years ago
Phillip Webb 700d3c3907 Relocate shaded JSON API in annotation-processor
Move the 'shade' copy of the JSON API to a separate src folder to make
it clearer that we don't own the code. Also polished some formatting
and suppressed a few warnings.

Closes gh-10307
7 years ago
Stephane Nicoll b9f4fd0b65 Fix exclude filter to not exclude MediaType
This commit removes MediaType from the list of exclude types as it looks
like an error: MediaType has a constructor taking a `String` and binding
works fine with it.

This has the effect of properly generating the metadata for the only key
that Spring Boot exposes with a MediaType type:
spring.data.rest.default-media-type.

Closes gh-11568
7 years ago
Stephane Nicoll 4568f14c71 Fix javadoc warnings 7 years ago
Stephane Nicoll d49b022ce3 Shade json in configuration processor
This commit shades the json API in the configuration processor so that
it doesn't bring `android-json` to the classpath anymore.

Closes gh-10307
7 years ago
Stephane Nicoll 397d3e85e8 Fix Windows build
Closes gh-11459
7 years ago
Douglas Cardoso feecc27677 Log inaccessible file in RandomAccessDataFile
Closes gh-11401
7 years ago
Phillip Webb 2c429ba77d Restore static final formatting
Restore static final constants to upper case formatting.

See gh-10457
7 years ago
Phillip Webb 6a55623910 Polish 7 years ago
dreis2211 d5370e6852 Precompile current dir pattern in Handler
Closes gh-11321
7 years ago
dreis2211 37437a0fe2 Avoid allocations from lower-casing spec in JAR Handler
Closes gh-11314
7 years ago
Stephane Nicoll 846e642631 Properly handle class reference
Previously, a condition on a class targeting an inner class would
generate an invalid String representation of it. Unfortunately, the
`toString` representation misses the `$` sign between the outer class
and the inner class name.

This commit post-processes the values to generate the appropriate
representation.

Closes gh-11282
7 years ago
Andy Wilkinson a491727b7c Avoid creating unnecessary garbage during URL normalization
Closes gh-11207
7 years ago
Sylwester Lachiewicz 0a6f5fb2be Update Apache Maven Central repository url
Closes gh-11190
7 years ago
Spring Buildmaster df2ae7aa19 Next Development Version 7 years ago
Stephane Nicoll 373f7db3b5 Add missing supported source version
Closes gh-10929
7 years ago
dreis2211 605e95145a Fix typos in ApplicationArguments and Library
Closes gh-10811
7 years ago
Johnny Lim 4979af9fa5 Remove unnecessary assignments
Closes gh-10805
7 years ago
Spring Buildmaster c0f9f64776 Next Development Version 7 years ago
Johnny Lim bfa291f671 Polish 7 years ago
Spring Buildmaster 30eb937a83 Next Development Version 7 years ago
Stephane Nicoll af18110226 Polish "Improve exception message for invalid source"
Closes gh-10130
7 years ago
Aurélien Pupier 44b60c72e3 Improve exception message for invalid source
See gh-10130
7 years ago
Andy Wilkinson 7a87c69dd0 Normalize spec when creating jar URL by removing /../ and /./
Previously when Handler was creating a URL from a context URL and a
spec, any occurrances of /../ or /./ in the spec would be left as-is.
This differed from the JDK's Handler implementation which normalizes
the URL by modifying the path to remove any occurrences of /../ or
/./

This commit updates our Handler implementation to align it with the
JDK's. Tests have been added to assert that, given the same inputs,
the two Handler classes produce the same output.

Closes gh-9917
7 years ago
Andy Wilkinson b7ac5f2eb2 Polish "Make JarURLConnection return entry's last modified time"
Closes gh-9893
7 years ago
rostislav.dudka 7c7259beec Make JarURLConnection return entry's last modified time
See gh-9893
7 years ago