Commit Graph

1471 Commits (5cf2e763778098032bf94bc510949f1620d86f3f)

Author SHA1 Message Date
Andy Wilkinson 85dc89e1b4 Make serialization of @ConfigurationProperties beans more defensive
Previously, serialization of a @ConfigurationProperties bean to JSON
would fail if:

- A property on the bean returned the bean (the bean was
  self-referential)
- An exception was thrown when attempting to retrieve a property's
  value.

This commit makes the serialization more defensive by skipping any
property that is affected by either of the problems described above.
Debug logging has been added to aid diagnosis of missing properties.

Closes gh-10846
7 years ago
Johnny Lim c718880354 Handle null early in Sanitizer.sanitize()
Closes gh-10806
7 years ago
Spring Buildmaster c0f9f64776 Next Development Version 7 years ago
Andy Wilkinson 43aa7dbaf1 Polish "Provide informative reason when rejecting request with invalid level"
See gh-10588
7 years ago
Eddú Meléndez 9e5a1b32c8 Provide informative reason when rejecting request with invalid level
Previously, bad request with no reason was included in the response.
This commit introduces the reason when invalid log level is sent in the
request.

Fixes gh-10588
7 years ago
Andy Wilkinson aca30950cf Polish "Align prefix match in BufferCounterService with DefaultCounterService"
See gh-10278
7 years ago
Venil Noronha dcb81a3da5 Align prefix match in BufferCounterService with DefaultCounterService
Closes gh-10278
7 years ago
Spring Buildmaster 30eb937a83 Next Development Version 7 years ago
Madhura Bhave 86cd7275a1 MVC endpoints bean methods are @ConditionalOnMissingBean
Fixes gh-10105
7 years ago
Paul Vorbach 04ca7f137d Identify and fix incomplete assertions
Several calls to assertThat lacked a following assertion most often due
to wrong use of parenthesis.

See gh-10084
7 years ago
Johnny Lim ee3de15e37 Add more ConditionalOnClass checks in HealthIndicatorAutoConfiguration
Closes gh-9940
7 years ago
Andy Wilkinson 5a8a86375d Sanitize individual env entry that is matched exactly
Closes gh-9918
See gh-8282
7 years ago
Stephane Nicoll 5c13b8bf50 Separate custom schema configuration for Liquibase test
Unfortunately, creating the schema in code did not offer the right
condition to reproduce the error scenario. This commit restore the
initial intent, but separating the configuration and cleaning the
created context properly.

See gh-9862
7 years ago
Stephane Nicoll 7736cb1dc5 Fix test so that it doesn't leave a datasource hanging around
Closes gh-9862
7 years ago
Stephane Nicoll 7e21178f63 Polish "Use configured schema in Liquibase endpoint"
Closes gh-9862
7 years ago
Craig Andrews 3e13970fe0 Use configured schema in Liquibase endpoint
This commit makes sure that the Liquibase endpoint uses the configured
schema.

See gh-98£62
7 years ago
Spring Buildmaster 17a5bb0be4 Next development version 7 years ago
Spring Buildmaster 41c5c0e7c9 Next development version 7 years ago
Johnny Lim d18e452fcd Use currentHealth consistently in getHealth()
Closes gh-9832
7 years ago
Andy Wilkinson bbc34a676c Polish "Handle possible regexes defensively in NamePatternFilter"
Closes gh-9730
7 years ago
dbego c29d1c756a Handle possible regexes defensively in NamePatternFilter
Previously, if a name contained part of a regex but wasn't actually
a regex, a PatternSyntaxException would be thrown and the request
would fail.

This commit updates NamePatternFilter to catch PatternSyntaxException
and treat the regex-like input as a name insteead.

See gh-9730
7 years ago
Phillip Webb 68910f2b8f Polish 7 years ago
Phillip Webb cd23de6ed5 Add more HealthIndicatorAutoConfiguration ordering
Update HealthIndicatorAutoConfiguration to ensure that it is configured
after ActiveMQAutoConfiguration.

Fixes gh-9793
7 years ago
孙健 1745a5ee6f Fix metric check in case of duplicate metric
Closes gh-9497
7 years ago
Madhura Bhave 0f8a819af9 Enable cors in default management security config
Fixes gh-9548
7 years ago
Phillip Webb aa57ca7e18 Polish 7 years ago
Stephane Nicoll 88d16ddf6b Add missing class check
Closes gh-9602
8 years ago
Andy Wilkinson 7a04708c41 Make sure the HealthMvcEndpoint is thread-safe
Previously, HealthMvcEndpoint stored the cached Health and its last
access time in two separate fields. Neither field was volatile and
no synchronization was used. This meant that there were potential
visibility problems. In a possible worst case scenario one field may
see the updated access time but an old health so it would incorrectly
believe that the old health was up-to-date and return it.

This commit reworks the endpoint to store the cached health and the
time at which it was created in a single, volatile field. This ensures
that the cached health and its creation time will be visible across
threads. Note that a race between threads when the cache is stale is
still possible. This race may result in multiple calls to the
delegate but these should be harmless.

Closes gh-9454
8 years ago
Stephane Nicoll 3f70638f1c Polish "Use getUsableSpace() in DiskSpaceHealthIndicator"
Closes gh-9544
8 years ago
Huang YunKun 158416fdd0 Use getUsableSpace() in DiskSpaceHealthIndicator
See gh-9544
8 years ago
Spring Buildmaster 05d4d0281c Next Development Version 8 years ago
Andy Wilkinson 9579e95868 Handle explicit disablement of management SSL correctly
Closes gh-9423
8 years ago
Phillip Webb b9fd99e268 Polish 8 years ago
Stephane Nicoll 9fc90a809f Add missing @Test annotations 8 years ago
Stephane Nicoll d4a0fe5ff9 Polish "Fix configuration properties output for actuator"
Closes gh-9052
8 years ago
Wesley Stratton 7d6293f79d Fix configuration properties output for actuator
See gh-9052
8 years ago
Stephane Nicoll 4cc515054e Merge branch '1.4.x' into 1.5.x 8 years ago
Stephane Nicoll a59000354c Support for TransactionAwareCacheDecorator
This commit makes sure to unwrap any transaction aware cache before
collecting metrics for them.

Closes gh-8984
8 years ago
Gytis Trikleris 00823d41a9 Log a warning if a health indicator throws an exception
Closes gh-9110
8 years ago
Phillip Webb 931ce15d7f Update copyright header dates 8 years ago
Phillip Webb 4a7dcc8786 Formatting 8 years ago
Madhura Bhave 3d836f7730 Fix test pollution 8 years ago
Madhura Bhave 189e07e9f3 Support values other than String in /env
Fixes gh-9079
8 years ago
Stephane Nicoll 5121b848e1 Making sure to stop embedded web servers in tests
Closes gh-9012
8 years ago
Phillip Webb 4d4d03ab2c Merge branch '1.4.x' into 1.5.x 8 years ago
Phillip Webb 4a95b2f174 Polish 8 years ago
Stephane Nicoll 035e27b1d1 Merge branch '1.4.x' into 1.5.x 8 years ago
Stephane Nicoll 8e5bf4b22a Polish CachePublicMetrics
CachePublicMetrics wasn't explicitly tested and was still using field
injection. This commit improves the situation in preparation of the fix
for gh-8984
8 years ago
Stephane Nicoll f42998f5ca Revert "Refine validator and MVC validator configuration"
This commit reverts c9561f0 and 69a8c0d and effectivly fixes gh-8979 but
reintroduces the issue reported in gh-8495.
8 years ago
Phillip Webb df82060cad Formatting 8 years ago