Commit Graph

5294 Commits (677f2bc80cc4b3a604b5be0eea288e377babe241)

Author SHA1 Message Date
Phillip Webb 867c4a14cb Clarify Javadoc for ServletContextInitializer
Closes gh-18660
5 years ago
wycm 681a94b0d5 Optimize debug level logs
See gh-18604
5 years ago
xiaokeliu666 57c64eb3bc Polish
See gh-18665
5 years ago
dreis2211 d17f11dbe1 Test the Gradle Plugin against Gradle 5.6.3
See gh-18648
5 years ago
Brian Clozel 9c5ee1126f Polish
See gh-18473
5 years ago
Brian Clozel e4fa9ce8c6 Deprecate server.connection-timeout property
Prior to this commit, all supported servers would share the same
configuration property `server.connection-timeout`. Unfortunately, in
many cases the behavior of this timeout changes depending on the server.
From actual connection setup timeout, to detecting and closing idle
connections, this property cannot be properly translated from one server
implementation to another.

This commit deprecates this configuration property and introduces server
specific properties:

* `server.jetty.connection-idle-timeout`
(Time that the connection can be idle before it is closed.)
* `server.netty.connection-timeout`
(Connection timeout of the Netty channel.)
* `server.tomcat.connection-timeout`
(Amount of time the connector will wait, after accepting a connection,
for the request URI line to be presented.)
* `server.undertow.no-request-timeout`
(Amount of time a connection can sit idle without processing a request,
before it is closed by the server.)

`server.connection-timeout` is now deprecated and will be removed in a
future release.

Fixes gh-18473
5 years ago
contextshuffling a8c6540191 Use LinkedHashSet for deterministic order in test assertion
See gh-18612
5 years ago
Andy Wilkinson 00d4b44cbb Remove trailing commas from test SQL scripts
Closes gh-18607
5 years ago
Stephane Nicoll e4ba6049ff Clarify scope of "@SpringBootTest#classes"
See gh-18229
5 years ago
Stephane Nicoll 22f44917ca Polish "Add metadata entry for spring.main.register-shutdown-hook"
See gh-18581
5 years ago
leoli 9b781449cf Add metadata entry for spring.main.register-shutdown-hook
See gh-18581
5 years ago
Stephane Nicoll f05d7902e2 Polish "Clarify formatting recommendations for configuration property javadoc"
See gh-18578
5 years ago
Rafiullah Hamedy 1f9b68707f Clarify formatting recommendations for configuration property javadoc
This commit adds a note to spring-boot-features.adoc to clarify that
using javadoc tags to format configuration property descriptions is not
supported.

See gh-18578
5 years ago
contextshuffling efedd80d4b Use LinkedHashSet for deterministic order in test assertions
See gh-18580
5 years ago
dreis2211 abfb87d1a3 Rename tests to match Surefire expectations
See gh-18579
5 years ago
王洋 152568521e Make the logger static final
See gh-18575
5 years ago
Ted M. Young f553784ebc Fix incorrect backslash escape in documentation sample
See gh-18546
5 years ago
dreis2211 ba46ab6a4f Remove accidental usage of UnsupportedOptionException
See gh-18539
5 years ago
Andy Wilkinson f42b442ce2 Fix handling of encoded URLs in Class-Path manifest attribute
Fixes gh-18410
5 years ago
Andy Wilkinson 3d4157ad6d Correct SCM URLs in published poms
Previously, Maven's default behaviour was relied up which resulted
in the artifact ID being appended to each URL as it was inherited.
This behaviour can only be disabled in Maven 3.6 and later, a version
that we cannot use due to an incompatibility with the Flatten Plugin.

This commit works around Maven's default behaviour by defining
properties for the SCM URL, connection, and developer connection and
then explicitly defining the settings in each pom using these
properties. The explicit definition of the properties in each pom
prevents them being inherited from the parent, thereby disabling the
unwanted appending of the artifact ID to the URL.

Fixes gh-18328
5 years ago
Phillip Webb 40acbfc733 Update copyright header of changed files 5 years ago
Madhura Bhave ecf393461e Skip management context ResourceConfigCustomizers
Update `JerseyManagementContextConfiguration` so that customizer beans
are not longer applied. The endpoint resource endpoints are now added
with a registrar bean `@PostConstruct` method.

Prior to this commit, when running the management server on a different
port a `Resource` added by a customizer could be added two different
`ResourceConfig` instance. This breaks the singleton contract expected
by Jersey.

Fixes gh-17801

Co-authored-by: Phillip Webb <pwebb@pivotal.io>
5 years ago
Johnny Lim 3a63179d81 Fix a broken Asciidoctor syntax
Along the way, this commit also fixes a typo.

Closes gh-18325
5 years ago
Stephane Nicoll b0d6169285 Upgrade to Spring Session Bom Bean-SR8
Closes gh-18466
5 years ago
Stephane Nicoll 9d40d192a0 Upgrade to Micrometer 1.1.7
Closes gh-18465
5 years ago
Stephane Nicoll 47365dc260 Revert to Spring Web Services 3.0.7.RELEASE
See gh-18315
5 years ago
Stephane Nicoll 1357f1b46c Upgrade to Spring AMQP 2.1.11.RELEASE
Closes gh-18312
5 years ago
Stephane Nicoll 00a9eeaaff Upgrade to Spring AMQP 2.1.11.RELEASE
Closes gh-18312
5 years ago
Stephane Nicoll a22046697e Upgrade to Spring Integration 5.1.8.RELEASE
Closes gh-18313
5 years ago
dreis2211 417bfc4c87 Fix comment position in ZipHeaderPeekInputStreamTests
See gh-18445
5 years ago
Stephane Nicoll 2fffa5675d Upgrade to Spring Data Lovelace-SR11
Closes gh-18414
5 years ago
Andy Wilkinson 0c8bb394f7 Upgrade to Spring REST Docs 2.0.4.RELEASE
Closes gh-18271
5 years ago
dreis2211 208fb8f1ef Add Mustache to 'Customize ViewResolvers' docs section
See gh-18378
5 years ago
Stephane Nicoll 17df6ab044 Start building against Spring Data Lovelace-SR11 snapshots
See gh-18414
5 years ago
Phillip Webb 38968d2fff Polish 'Apply TTL invocation caching on reactor types'
Extract reactor specific code to an inner class to protect
against ClassNotFound exceptions if reactor is not in use.

Also add support for `Flux`.

See gh-18339
5 years ago
dreis2211 33d8bfa99d Apply TTL invocation caching on reactor types
Update `CachingOperationInvoker` so that TTL caching is applied directly
to reactive types. Prior to this commit, a `Mono` would be cached, but
the values that it emitted would not.

See gh-18339
5 years ago
Tadaya Tsuyukubo bccdf04358 Use ordered TaskExecutorCustomizers
Use an ordered stream in `TaskExecutionAutoConfiguration` when
obtaining the TaskExecutor customizers.

See gh-18333
5 years ago
Stephane Nicoll 865a1cd994 Upgrade to Spring Framework 5.1.10.RELEASE
Closes gh-18238
5 years ago
Stephane Nicoll d83e3f9070 Upgrade to Lombok 1.18.10
Closes gh-18407
5 years ago
Stephane Nicoll 526f2516e0 Upgrade to Postgresql 42.2.8
Closes gh-18406
5 years ago
Stephane Nicoll ed04be78f4 Upgrade to Neo4j Ogm 3.1.14
Closes gh-18405
5 years ago
Stephane Nicoll 278cffffc5 Upgrade to Hibernate 5.3.12.Final
Closes gh-18404
5 years ago
Stephane Nicoll b0a48c6303 Upgrade to Tomcat 9.0.26
Closes gh-18403
5 years ago
Stephane Nicoll d8f17d318d Upgrade to Httpclient 4.5.10
Closes gh-18402
5 years ago
Stephane Nicoll 82e00d1b2d Upgrade to Joda Time 2.10.4
Closes gh-18401
5 years ago
Stephane Nicoll 94402f4d77 Upgrade to Netty Tcnative 2.0.26.Final
Closes gh-18400
5 years ago
Stephane Nicoll 3ed1713915 Polish 5 years ago
Johnny Lim 7319908b40 Polish
See gh-18347
5 years ago
Roland Weisleder 92ae7b21a1 Fix typo in ApplicationContextAssert
See gh-18372
5 years ago
Phillip Webb 050460f635 Check factory bean for EntityManager datasource
Update `DataSourceInitializedPublisher` to fallback to the
`LocalContainerEntityManagerFactoryBean` if the
`javax.persistence.nonJtaDataSource` property is not defined.

As of Hibernate 4.3 the property is no longer set if the `EntityManager`
is created from a `PersistenceUnitInfo` instance rather than actual
properties.

Although this is being addressed in Hibernate issue HHH-13432, it's
not strictly a requirement of the JPA spec that the property is set.

Fixes gh-17061
5 years ago
Stephane Nicoll 56623bd57b Upgrade to Reactor Californium-SR12
Closes gh-18348
5 years ago
Madhura Bhave 342a0535d7 Explicitly configure SecurityWebFilterChain bean for reactive oauth2 client
This will ensure that ReactiveManagementWebSecurityAutoConfiguration backs
off and that the actuator endpoints are also secured via OAuth2.

Fixes gh-17949
5 years ago
Andy Wilkinson c613418451 Suppress body when handling a no content (204) "error"
Fixes gh-18136
5 years ago
Andy Wilkinson 35ad5cd011 Fix intermittent failure of inMemoryDerbyIsShutdown 5 years ago
Andy Wilkinson 419f92d381 Tune @ConditionalOnMissingBean for interface-based back off
Previously, a number of usages of @ConditionalOnMissingBean prevented
a bean that implements an auto-configured bean's "main" interface from
causing the auto-configuration of the bean to back off. This would
happen when @ConditionalOnMissingBean did not specify a type, the
@Bean method returned the bean's concrete type, and that concreate
type implements a "main" interface.

This commit updates such usages of @ConditionalOnMissingBean to
specify the "main" interface as the type of the bean that must be
missing. This will allow, for example, the auto-configured
MongoTemplate bean to back off when a MongoOperations bean is defined.

Fixes gh-18101
5 years ago
dreis2211 d89adfac91 Test compression with invalid content type for all webservers
Closes gh-18338
5 years ago
leoli 09cf1e6791 Fix property name in "Task Execution and Scheduling" example
See gh-18331
5 years ago
Andy Wilkinson 9df356ec4c Fix destination checking in Artemis auto-configuration tests
Closes gh-18319
5 years ago
Stephane Nicoll 7533bfd0d3 Start building against Spring Web Services 3.0.8 snapshots
See gh-18315
5 years ago
Stephane Nicoll f6589e66c2 Start building against Spring Kafka 2.2.9 snapshots
See gh-18314
5 years ago
Stephane Nicoll d38d3ea940 Start building against Spring Integration 5.1.8 snapshots
See gh-18313
5 years ago
Stephane Nicoll 05f857d1f1 Start building against Spring AMQP 2.1.11 snapshots
See gh-18312
5 years ago
Andy Wilkinson e5f26a4f1a Rename test resource to be Windows-friendly 5 years ago
Phillip Webb 1ceb96f9f2 Ensure matches is not called before initialization
Update `ApplicationContextRequestMatcher` to ensure that the `matches`
method is never called before `initialized`. This fixes an issue
accidentally introduced in commit 5938ca78 where concurrent calls
to `matches` could trigger unexpected errors due to the fact that the
second call proceeded before the `initialized` method had returned.

Fixes gh-18211
5 years ago
Phillip Webb 5427526bcc Fix ApplicationContextRequestMatcher javadoc
Fix an error in the `ApplicationContextRequestMatcher` javadoc.
5 years ago
aohana 51a8c73b7b Test custom comment prefix with one that does not work by default
See gh-18285
5 years ago
Alessandro Falappa b1750defde Fix typo in configuration metadata appendix
See gh-18289

Closes gh-18289
5 years ago
Madhura Bhave 3c4449bf0e Polish "Fix typo in logback example"
See gh-18295
5 years ago
Harald Brabenetz 0091c04720 Fix typo in logback example
See gh-18295
5 years ago
Madhura Bhave f9d94c6ed0 Remove duplicate word in docs 5 years ago
Alessandro Falappa 6dab9bb224 Fix pre-defined logging group documentation
See gh-18270
5 years ago
Stephane Nicoll 9434cb0e22 Keep a live reference of protocol resolvers rather than copying them
This commit makes sure that any subsequent call on addProtocolResolver
on the context will impact the ResourceLoader implementation that
DevTools sets on the context.

This makes sure that any custom ProtocolResolver that is set later in
the lifecycle is taken into account.

Closes gh-17214
5 years ago
Stephane Nicoll a642421661 Force creation of sources jar
Closes gh-18212
5 years ago
Stephane Nicoll 9065c4997d Fix rebase from master 5 years ago
Stephane Nicoll e05f42f0f3 Polish Add Testable to CLASS_ANNOTATIONS in TestTypeExcludeFilter"
See gh-18214
5 years ago
Leonard Brünings b9c8d7dd60 Add Testable to CLASS_ANNOTATIONS in TestTypeExcludeFilter
See gh-18214
5 years ago
Andy Wilkinson b1ca1ae6e9 Add missing dependency management for Janino modules
Closes gh-18225
5 years ago
Peter Sauer dba18ce778 Fix minor typo
The phrase `We have you covered.` is a sentence and so it should start
with a capital `W`.

See gh-18216
5 years ago
Phillip Webb 23174eb484 Remember annotations when using withExistingValue
Update `Bindable` builder methods so that existing annotations are
retained.

Closes gh-18218
5 years ago
Andy Wilkinson 4f21b51a2b Polish one sentence per line in the reference docs 5 years ago
Andy Wilkinson 7b1e10ed00 Use one sentence per line in Actuator and Gradle plugin doc source
Closes gh-18185
5 years ago
Andy Wilkinson 795c2f225f Support getComment() on a nested JarFile
Previously, calling getComment() on a nested jar file would result
in the outer jar file's comment being returned.

This commit updates the loader's JarFile to read the file's comment
from the central directory end record and return it from getComment().

Fixes gh-18128
5 years ago
dreis2211 ae30515e5e Test the Gradle Plugin against Gradle 5.6.2
See gh-18164
5 years ago
Andy Wilkinson 19ccfaea86 Fix QuartzAutoConfiguration when Liquibase is not on the class path
Fixes gh-18153
5 years ago
Andy Wilkinson 8882c532cd Correct attribute references in reference documentation
Fixes gh-18163
5 years ago
Stephane Nicoll 9cd93ac98f Upgrade to Httpcore 4.4.12
Closes gh-18144
5 years ago
Stephane Nicoll 5fe4f3b25a Upgrade to Activemq 5.15.10
Closes gh-18143
5 years ago
Stephane Nicoll fd77fd4f05 Upgrade to Undertow 2.0.26.Final
Closes gh-18142
5 years ago
Stephane Nicoll e978f9ac8e Upgrade to Reactor Bom Californium-SR11
Closes gh-18141
5 years ago
Stephane Nicoll 85a44dff64 Upgrade to Micrometer 1.1.6
Closes gh-18133
5 years ago
Phillip Webb a3cde7fd8d Fix typo 5 years ago
Phillip Webb a0a204ae6a Clarify devtools trigger file documentation
Closes gh-17775
5 years ago
Phillip Webb f1bbb2a017 Fix documentation typos
See gh-16718
5 years ago
Andy Wilkinson 29080b87ec Protect autoconfigure module against slow starting test containers 5 years ago
Andy Wilkinson 7f62c5a283 Provide a How-To for customizing Reactor Netty's TcpClient
Closes gh-17856
5 years ago
Phillip Webb 624c118cdf Polish "Document the pros and cons of MockMvc"
See gh-16718
5 years ago
Tetsuya Hasegawa 8f8a4af001 Document the pros and cons of MockMvc
Update the MockMvc documentation to provide more details about the
pros and cons of such an approach, specifically calling out the
difference with error page handling.

See gh-16718
5 years ago
Phillip Webb 158e25c00f Extend documentation on logback include files
Expand the Logback "How To" to provide further clarifications on
the different include files available.

See gh-16901
5 years ago
michal 1f97a60d16 Clarify documentation on logback include files
Update documentation and comments on Logback to show the correct
use of `default.xml` rather than `base.xml`.

See gh-16901
5 years ago
Phillip Webb 43108d5495 Add @SpringBootApplication.scanBasePackages note
Update the javadoc to note that `scanBasePackages` only affects the
`@ComponentScan` annotation and isn't a replacement for `@EntityScan`
or `@Enable...Repositories`.

Closes gh-18109
5 years ago
Phillip Webb e8d9b6f498 Polish "Fallback to ping if Solr URL references core"
See gh-16477
5 years ago
Markus Schuch b9764e8de8 Fallback to ping if Solr URL references core
Update `SolrHealthIndicator` to fallback to a basic ping operation if
the `baseUrl` references a particular core rather than the root context.

Prior to this commit, if the Solr `baseUrl` pointed to a particular
core then the health indicator would incorrectly report `DOWN`.

See gh-16477
5 years ago
Johnny Lim 2eac53cc5d Fix typo in deprecation reason for liquibase.check-change-log-location
See gh-18100
5 years ago
Andy Wilkinson 52311ffe3c Depend on FlywayMigrationInitializer beans by type not name
Previously, a custom FlywayMigrationInitializer bean named anything
other than flywayInitializer could result in a
NoSucBeanDefinitionException as the dependencies set up for JPA and
JDBC components used the bean name flywayInitializer.

This commit updates the configuration of the dependencies to depend
on FlywayMigrationInitializer beans by type rather than name.

Fixes gh-18105
5 years ago
Andy Wilkinson f313bf27a1 Depend on Flyway beans by type not name
Previously, a custom Flyway bean named anything other than flyway
could result in a NoSucBeanDefinitionException as the dependencies
set up for JPA and JDBC components used the bean name flyway.

This commit updates the configuration of the dependencies to depend
on Flyway beans by name rather than type.

Fixes gh-18102
5 years ago
dreis2211 087795fb67 Remove duplicated dependency in spring-boot-docs
See gh-18092
5 years ago
Andy Wilkinson abba4fa9c9 Include exception's message in message printed by AP
Fixes gh-17974
5 years ago
Andy Wilkinson edcaee375f Consider @Deprecated on field when determining property's deprecation
Fixes gh-17550
5 years ago
Andy Wilkinson 4fd7b68f71 Polish 5 years ago
Phillip Webb a86258e62c Revert "Reduce bean method visibility"
Reverts commit 2be3027dcf
on 2.1.x
5 years ago
Phillip Webb 2be3027dcf Reduce bean method visibility
See gh-17539
5 years ago
Phillip Webb 75a1a24914 Polish "Ensure Flyway/Liquibase runs before Quartz"
See gh-17539
5 years ago
Dmytro Nosan 7e5bd1f281 Ensure Flyway/Liquibase runs before Quartz
Add post processors to ensure that SchedulerFactoryBean and Scheduler
beans depend on the Flyway and Liquibase beans.

See gh-17539
5 years ago
Andy Wilkinson 7150f121a3 Redirect stdout from cd to /dev/null in CLI's bash script
Fixes gh-17579
5 years ago
Andy Wilkinson ee89e0effd Fix client auth with Jetty
Fixes gh-17541
5 years ago
Phillip Webb e07889b092 Document that Filter beans are eagerly initialized
Closes gh-17814
5 years ago
Phillip Webb 7e60f4b32a Clarify "YAML Shortcomings" documentation
Closes gh-17933
5 years ago
Phillip Webb ffbd11caba Document logger environment variable restrictions
Update the reference guide with a note about using environment variables
to configure logging.

Closes gh-17958
5 years ago
Andy Wilkinson 37d3ce03f8 Revert "Upgrade to Jetty 9.4.20.v20190813"
This reverts commit f6f99d7855 as 9.4.20
includes an incompatible class change where an abstract class in
Jetty's public API was changed to an interface, making it incompatible
with Framework 5.1.9.

See gh-18035
5 years ago
Andy Wilkinson 3fc4df9f66 Upgrade to Slf4j 1.7.28
Closes gh-18043
5 years ago
Andy Wilkinson e12aa4fe51 Upgrade to Reactive Streams 1.0.3
Closes gh-18042
5 years ago
Andy Wilkinson df186945b6 Upgrade to Neo4j Ogm 3.1.13
Closes gh-18041
5 years ago
Andy Wilkinson 1cf615059e Upgrade to Jooq 3.11.12
Closes gh-18040
5 years ago
Andy Wilkinson 9c8b8ef6cf Upgrade to Jboss Logging 3.3.3.Final
Closes gh-18039
5 years ago
Andy Wilkinson f2ca07001d Upgrade to Infinispan 9.4.16.Final
Closes gh-18038
5 years ago
Andy Wilkinson 07f3ba7c33 Upgrade to Hibernate 5.3.11.Final
Closes gh-18037
5 years ago
Andy Wilkinson 7948c0e399 Upgrade to Freemarker 2.3.29
Closes gh-18036
5 years ago
Andy Wilkinson f6f99d7855 Upgrade to Jetty 9.4.20.v20190813
Closes gh-18035
5 years ago
Andy Wilkinson 5e2f18f48b Upgrade to Groovy 2.5.8
Closes gh-18034
5 years ago
Andy Wilkinson a2d452f160 Upgrade to Tomcat 9.0.24
Closes gh-18033
5 years ago
Andy Wilkinson b33d376fbe Upgrade to Undertow 2.0.25.Final
Closes gh-18032
5 years ago
Andy Wilkinson bf27f23144 Upgrade to Rxjava2 2.2.12
Closes gh-18031
5 years ago
Andy Wilkinson 494eaf0df8 Upgrade to Netty 4.1.39.Final
Closes gh-18030
5 years ago
Andy Wilkinson e9a2de0556 Upgrade to Dropwizard Metrics 4.0.6
Closes gh-18029
5 years ago
Andy Wilkinson 8956e3d216 Upgrade to Couchbase Client 2.7.9
Closes gh-18028
5 years ago
Andy Wilkinson 3d23277b8f Tolerate invalid mimetype in Reactory Netty compression predicate
Fixes gh-18018
5 years ago
Phillip Webb 6ca92418b5 Document need to exactly JPA property names
Closes gh-17975
5 years ago
Phillip Webb e4dfb74629 Polish 5 years ago
Phillip Webb 1ff784ff54 Remove MBean shutdown warning from documentation
Closes gh-17988
5 years ago
Phillip Webb 368eb566fb Use versioned links in documentation
Update the reference documentation to use versioned links rather then
`/current/` whenever possible.

Closes gh-18000
5 years ago
Phillip Webb 348d65b4fe Polish documentation 5 years ago
Phillip Webb 7f9d143e01 Polish documentation
Update reference documentation source to use consistent attribute names
and fix a few formatting issues.
5 years ago
Phillip Webb db26d9dc91 Fix EndpointRequest ignore logic
Fixup ignore logic in `EndpointRequest`.

See gh-18012
5 years ago
Phillip Webb 572e491465 Remove Gemfire starter details from documentation
Closes gh-18002
5 years ago
Phillip Webb dbccb705a8 Clarify "Web Application Conditions" documentation
Update the reference documentation so that "Web Application Conditions"
also covers reactive contexts.

Closes gh-18005
5 years ago
Phillip Webb 5938ca78b6 Fix request matcher management context support
Fix caching issues in `ApplicationContextRequestMatcher` and allow
subclasses to ignore an application context entirely. Update existing
matcher implementations so that they deal with the management context
correctly.

Prior to this commit, the `ApplicationContextRequestMatcher` would
return a context cached from the first request. It also didn't
provide any way to ignore a context. This meant that if the user was
running the management server on a different port the matching results
could be inconsistent depending on if the first request arrived on
the regular context or the management context. It also meant that we
could not distinguish between the regular context and the management
context when matching.

Closes gh-18012
5 years ago
dreis2211 b6fff67f6e Remove reference to non-existent --edit option in CLI docs
See gh-18015
5 years ago
Phillip Webb 64d4bf823a Reformat documentation to one sentence per line
Update reference documentation to use one sentence per line formatting
as recommended by the Asciidoctor team.

Closes gh-12445
5 years ago
Ben Hale 2a04d94cf1 Use exec when launching the JVM in CLI's shell script
Previously, when the Spring Boot CLI ran the Java command line for an
application it did a straight invocation which suppressed propagation of
signals to the JVM in certain circumstances (e.g within Docker containers).

This change prepends the command with exec which causes the Java process to
replace the script process in a shell ensuring that signals are propagated to
the Java process without suppression.

See gh-17976

Signed-off-by: Ben Hale <bhale@pivotal.io>
5 years ago
dreis2211 26a22fa523 Test the Gradle Plugin against Gradle 5.6.1
See gh-17984

Closes gh-17984
5 years ago