Commit Graph

1503 Commits (912eb53d7ab56fd5ae50c1866bd66fbfa5c45d78)

Author SHA1 Message Date
Johnny Lim e7cb1c63bb Fix typo
Closes gh-13755
6 years ago
Andy Wilkinson 2f952fde6c Polish 6 years ago
Andy Wilkinson 454de0bfd7 Polish 6 years ago
Andy Wilkinson 24d5209738 Polish “Close Database to reset Connection's auto commit property”
Closes gh-13559
6 years ago
dmsergeevp44 3498a91259 Close Database to reset Connection's auto commit property
Previously, LiquibaseEndpoint closed the JdbcConnection but did not
close the Database. When using a connection pool, this could leave the
underlying SQL Connection with its auto commit property set to false.

This commit updates LiquibaseEndpoint to close the Database. This
ensures that it resets that Connection's auto commit property to the
value that it had when the Database was configured to use the
Connection.

See gh-13559
6 years ago
Andy Wilkinson b35e1ad232 Avoid unbounded metrics creation for requests not handled by Spring MVC
Previously, if an HTTP request that used a templated URI was handled
by something other than Spring MVC, a potentially unbounded number of
metrics would be created. This happened because, in the absence of
Spring MVC's best matching pattern attribute, MetricsFilter would fall
back to using the request's path. If the handling route was templated,
MetricsFilter would be unaware and would record different metrics for
each different path, rather than a single metric for the matching
pattern.

This cimmit updates MetricsFilter so that it falls back to using
unmapped when Spring MVC's best matching pattern attribute is not
available. This ensures that an unbounded number of metrics will no
longer be created, at the cost of losing specific metrics for requests
that are not handled by Spring MVC and that do not use a templated
path.

Closes gh-5875
7 years ago
Spring Buildmaster 36b8639853 Next Development Version 7 years ago
Stephane Nicoll 6b86190ae8 Remove unnecessary ConfigurationProperties
Closes gh-13412
7 years ago
Andy Wilkinson a9645a3d07 Polish 7 years ago
Spring Buildmaster 010b4fccbd Next development version 7 years ago
Phillip Webb 99dad81e9a Update copyright header year for changed files 7 years ago
Phillip Webb 0a0247975c Formatting 7 years ago
Phillip Webb 4e96587dc8 Polish modifier declaration ordering
Follow that Java language specification.
7 years ago
Phillip Webb 64930d4e5b Polish caught exception names
Prefer `ex` over `e`.
7 years ago
Phillip Webb 3ee777e142 Polish ternary expressions
Consistently format ternary expressions and always favor `!=` as the
the check.
7 years ago
Spring Buildmaster c10aad165f Next Development Version 7 years ago
Andy Wilkinson cd0e4fe945 Sanitize sun.java.command by default
Closes gh-12796
7 years ago
Spring Buildmaster ade4760842 Next Development Version 7 years ago
Phillip Webb a8f366a554 Fix copyright header for edited files 7 years ago
Stephane Nicoll b4a7e1d64b Use toLowerCase() and toUpperCase() with Locale.ENGLISH
This commit updates all `toLowerCase()` and `toUpperCase` invocations to
use the variant that takes a `Locale` to avoid locale-specific side
effect.

Closes gh-12213
7 years ago
Phillip Webb 798522d890 Format with Eclipse Oxygen SR2 7 years ago
Spring Buildmaster 6414b42335 Next Development Version 7 years ago
Phillip Webb 61f7bd8576 Polish 7 years ago
Andy Wilkinson 9da6ddb253 Trace IDs of sessions created downstream of trace filter
Closes gh-11717
7 years ago
Andy Wilkinson 451a4dfc7f Make management web security back off without spring-security-web
Closes gh-11474
7 years ago
Phillip Webb 6a55623910 Polish 7 years ago
Stephane Nicoll 7fb0bd77cd Polish "Handle null Principal in AuditEvent"
Closes gh-11320
7 years ago
nklmish 6b6a01a7e7 Handle null Principal in AuditEvent
See gh-11320
7 years ago
Andy Wilkinson 654fe9a31c Use Checkstyle to police accidental use of unwanted imports
Closes gh-11271
7 years ago
Stephane Nicoll 7b8adfab41 Polish 7 years ago
Spring Buildmaster df2ae7aa19 Next Development Version 7 years ago
Andy Wilkinson 276a9a0eec Reflect each source's values in env endpoint's response
Previously, the env endpoint would use the entire environment to
get the value of each property in a source. This meant that when
there were multiple sources with the same property, the value from
the source with the highest precedence would be used for every
source that contains the property.

This commit update the endpoint to retrieve the value from the
property source that is being described, rather than resolving it
against all the environment's property sources.

Closes gh-10883
7 years ago
Andy Wilkinson 85dc89e1b4 Make serialization of @ConfigurationProperties beans more defensive
Previously, serialization of a @ConfigurationProperties bean to JSON
would fail if:

- A property on the bean returned the bean (the bean was
  self-referential)
- An exception was thrown when attempting to retrieve a property's
  value.

This commit makes the serialization more defensive by skipping any
property that is affected by either of the problems described above.
Debug logging has been added to aid diagnosis of missing properties.

Closes gh-10846
7 years ago
Johnny Lim c718880354 Handle null early in Sanitizer.sanitize()
Closes gh-10806
7 years ago
Spring Buildmaster c0f9f64776 Next Development Version 7 years ago
Andy Wilkinson 43aa7dbaf1 Polish "Provide informative reason when rejecting request with invalid level"
See gh-10588
7 years ago
Eddú Meléndez 9e5a1b32c8 Provide informative reason when rejecting request with invalid level
Previously, bad request with no reason was included in the response.
This commit introduces the reason when invalid log level is sent in the
request.

Fixes gh-10588
7 years ago
Andy Wilkinson aca30950cf Polish "Align prefix match in BufferCounterService with DefaultCounterService"
See gh-10278
7 years ago
Venil Noronha dcb81a3da5 Align prefix match in BufferCounterService with DefaultCounterService
Closes gh-10278
7 years ago
Spring Buildmaster 30eb937a83 Next Development Version 7 years ago
Madhura Bhave 86cd7275a1 MVC endpoints bean methods are @ConditionalOnMissingBean
Fixes gh-10105
7 years ago
Paul Vorbach 04ca7f137d Identify and fix incomplete assertions
Several calls to assertThat lacked a following assertion most often due
to wrong use of parenthesis.

See gh-10084
7 years ago
Johnny Lim ee3de15e37 Add more ConditionalOnClass checks in HealthIndicatorAutoConfiguration
Closes gh-9940
7 years ago
Andy Wilkinson 5a8a86375d Sanitize individual env entry that is matched exactly
Closes gh-9918
See gh-8282
7 years ago
Stephane Nicoll 5c13b8bf50 Separate custom schema configuration for Liquibase test
Unfortunately, creating the schema in code did not offer the right
condition to reproduce the error scenario. This commit restore the
initial intent, but separating the configuration and cleaning the
created context properly.

See gh-9862
7 years ago
Stephane Nicoll 7736cb1dc5 Fix test so that it doesn't leave a datasource hanging around
Closes gh-9862
7 years ago
Stephane Nicoll 7e21178f63 Polish "Use configured schema in Liquibase endpoint"
Closes gh-9862
7 years ago
Craig Andrews 3e13970fe0 Use configured schema in Liquibase endpoint
This commit makes sure that the Liquibase endpoint uses the configured
schema.

See gh-98£62
7 years ago
Spring Buildmaster 17a5bb0be4 Next development version 7 years ago
Spring Buildmaster 41c5c0e7c9 Next development version 7 years ago