See gh-25980
pull/26041/head
izeye 4 years ago committed by Stephane Nicoll
parent 5e03612a53
commit 4987880afa

@ -209,13 +209,13 @@ class WebFluxTagsTests {
} }
@Test @Test
void outcomeTagIsClientErrorWhenExceptionIsDisconnectedClient() { void outcomeTagIsUnknownWhenExceptionIsDisconnectedClient() {
Tag tag = WebFluxTags.outcome(this.exchange, new EOFException("broken pipe")); Tag tag = WebFluxTags.outcome(this.exchange, new EOFException("broken pipe"));
assertThat(tag.getValue()).isEqualTo("UNKNOWN"); assertThat(tag.getValue()).isEqualTo("UNKNOWN");
} }
@Test @Test
void outcomeTagIsClientErrorWhenExceptionIsCancelledExchange() { void outcomeTagIsUnknownWhenExceptionIsCancelledExchange() {
Tag tag = WebFluxTags.outcome(this.exchange, new CancelledServerWebExchangeException()); Tag tag = WebFluxTags.outcome(this.exchange, new CancelledServerWebExchangeException());
assertThat(tag.getValue()).isEqualTo("UNKNOWN"); assertThat(tag.getValue()).isEqualTo("UNKNOWN");
} }

@ -29,7 +29,7 @@ import static org.assertj.core.api.Assertions.assertThat;
* *
* @author Brian Clozel * @author Brian Clozel
*/ */
public class NettyAutoConfigurationTests { class NettyAutoConfigurationTests {
private final ApplicationContextRunner contextRunner = new ApplicationContextRunner() private final ApplicationContextRunner contextRunner = new ApplicationContextRunner()
.withConfiguration(AutoConfigurations.of(NettyAutoConfiguration.class)); .withConfiguration(AutoConfigurations.of(NettyAutoConfiguration.class));

@ -2206,7 +2206,7 @@ To add to the default tags, provide one or more ``@Bean``s that implement `WebMv
To replace the default tags, provide a `@Bean` that implements `WebMvcTagsProvider`. To replace the default tags, provide a `@Bean` that implements `WebMvcTagsProvider`.
TIP: In some cases, exceptions handled in Web controllers are not recorded as request metrics tags. TIP: In some cases, exceptions handled in Web controllers are not recorded as request metrics tags.
Applications can opt-in and record exceptions by <<spring-boot-features.adoc#boot-features-error-handling, setting handled exceptions as request parameters>>. Applications can opt-in and record exceptions by <<spring-boot-features.adoc#boot-features-error-handling, setting handled exceptions as request attributes>>.
@ -2245,7 +2245,7 @@ To add to the default tags, provide one or more ``@Bean``s that implement `WebFl
To replace the default tags, provide a `@Bean` that implements `WebFluxTagsProvider`. To replace the default tags, provide a `@Bean` that implements `WebFluxTagsProvider`.
TIP: In some cases, exceptions handled in controllers and handler functions are not recorded as request metrics tags. TIP: In some cases, exceptions handled in controllers and handler functions are not recorded as request metrics tags.
Applications can opt-in and record exceptions by <<spring-boot-features.adoc#boot-features-webflux-error-handling, setting handled exceptions as request parameters>>. Applications can opt-in and record exceptions by <<spring-boot-features.adoc#boot-features-webflux-error-handling, setting handled exceptions as request attributes>>.

@ -35,7 +35,7 @@ import org.springframework.web.server.ServerWebExchange;
public interface ErrorAttributes { public interface ErrorAttributes {
/** /**
* Name of the {@link ServerRequest#attribute(String)} Request attribute} holding the * Name of the {@link ServerRequest#attribute(String) request attribute} holding the
* error resolved by the {@code ErrorAttributes} implementation. * error resolved by the {@code ErrorAttributes} implementation.
* @since 2.5.0 * @since 2.5.0
*/ */

@ -36,7 +36,7 @@ public interface ErrorAttributes {
/** /**
* Name of the {@link javax.servlet.http.HttpServletRequest#getAttribute(String) * Name of the {@link javax.servlet.http.HttpServletRequest#getAttribute(String)
* Request attribute} holding the error resolved by the {@code ErrorAttributes} * request attribute} holding the error resolved by the {@code ErrorAttributes}
* implementation. * implementation.
* @since 2.5.0 * @since 2.5.0
*/ */

Loading…
Cancel
Save