Use InvocationOnMock.getArgument() where possible

Closes gh-11818
pull/11811/merge
dreis2211 7 years ago committed by Stephane Nicoll
parent fac8970366
commit c1675c2d5f

@ -1,5 +1,5 @@
/* /*
* Copyright 2012-2017 the original author or authors. * Copyright 2012-2018 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -50,12 +50,12 @@ public class MockCachingProvider implements CachingProvider {
final Map<String, Cache> caches = new HashMap<>(); final Map<String, Cache> caches = new HashMap<>();
given(cacheManager.getCacheNames()).willReturn(caches.keySet()); given(cacheManager.getCacheNames()).willReturn(caches.keySet());
given(cacheManager.getCache(anyString())).willAnswer((invocation) -> { given(cacheManager.getCache(anyString())).willAnswer((invocation) -> {
String cacheName = (String) invocation.getArguments()[0]; String cacheName = invocation.getArgument(0);
return caches.get(cacheName); return caches.get(cacheName);
}); });
given(cacheManager.createCache(anyString(), any(Configuration.class))) given(cacheManager.createCache(anyString(), any(Configuration.class)))
.will((invocation) -> { .will((invocation) -> {
String cacheName = (String) invocation.getArguments()[0]; String cacheName = invocation.getArgument(0);
Cache cache = mock(Cache.class); Cache cache = mock(Cache.class);
given(cache.getName()).willReturn(cacheName); given(cache.getName()).willReturn(cacheName);
caches.put(cacheName, cache); caches.put(cacheName, cache);

@ -62,8 +62,8 @@ public class MockRestarter implements TestRule {
given(this.mock.getInitialUrls()).willReturn(new URL[] {}); given(this.mock.getInitialUrls()).willReturn(new URL[] {});
given(this.mock.getOrAddAttribute(anyString(), any(ObjectFactory.class))) given(this.mock.getOrAddAttribute(anyString(), any(ObjectFactory.class)))
.willAnswer((invocation) -> { .willAnswer((invocation) -> {
String name = (String) invocation.getArguments()[0]; String name = invocation.getArgument(0);
ObjectFactory factory = (ObjectFactory) invocation.getArguments()[1]; ObjectFactory factory = invocation.getArgument(1);
Object attribute = MockRestarter.this.attributes.get(name); Object attribute = MockRestarter.this.attributes.get(name);
if (attribute == null) { if (attribute == null) {
attribute = factory.getObject(); attribute = factory.getObject();

@ -1,5 +1,5 @@
/* /*
* Copyright 2012-2017 the original author or authors. * Copyright 2012-2018 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -90,7 +90,7 @@ public class HttpTunnelServerTests {
this.server = new HttpTunnelServer(this.serverConnection); this.server = new HttpTunnelServer(this.serverConnection);
given(this.serverConnection.open(anyInt())).willAnswer((invocation) -> { given(this.serverConnection.open(anyInt())).willAnswer((invocation) -> {
MockServerChannel channel = HttpTunnelServerTests.this.serverChannel; MockServerChannel channel = HttpTunnelServerTests.this.serverChannel;
channel.setTimeout((Integer) invocation.getArguments()[0]); channel.setTimeout(invocation.getArgument(0));
return channel; return channel;
}); });
this.servletRequest = new MockHttpServletRequest(); this.servletRequest = new MockHttpServletRequest();

@ -69,7 +69,7 @@ public abstract class MockServletWebServer {
given(this.servletContext.addServlet(anyString(), any(Servlet.class))) given(this.servletContext.addServlet(anyString(), any(Servlet.class)))
.willAnswer((invocation) -> { .willAnswer((invocation) -> {
RegisteredServlet registeredServlet = new RegisteredServlet( RegisteredServlet registeredServlet = new RegisteredServlet(
(Servlet) invocation.getArguments()[1]); invocation.getArgument(1));
MockServletWebServer.this.registeredServlets MockServletWebServer.this.registeredServlets
.add(registeredServlet); .add(registeredServlet);
return registeredServlet.getRegistration(); return registeredServlet.getRegistration();
@ -77,7 +77,7 @@ public abstract class MockServletWebServer {
given(this.servletContext.addFilter(anyString(), any(Filter.class))) given(this.servletContext.addFilter(anyString(), any(Filter.class)))
.willAnswer((invocation) -> { .willAnswer((invocation) -> {
RegisteredFilter registeredFilter = new RegisteredFilter( RegisteredFilter registeredFilter = new RegisteredFilter(
(Filter) invocation.getArguments()[1]); invocation.getArgument(1));
MockServletWebServer.this.registeredFilters.add(registeredFilter); MockServletWebServer.this.registeredFilters.add(registeredFilter);
return registeredFilter.getRegistration(); return registeredFilter.getRegistration();
}); });

Loading…
Cancel
Save