Polish

spring-boot-project/spring-boot-actuator-autoconfigure/src/test/java/org/springframework/boot/actuate/autoconfigure/web/server/ManagementServerPropertiesTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/jdbc/DataSourceInitializerPostProcessor.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/groovy/template/GroovyTemplateAutoConfigurationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jdbc/DataSourceAutoConfigurationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jms/activemq/ActiveMQAutoConfigurationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/jms/activemq/ActiveMQPropertiesTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/ServerPropertiesTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/web/reactive/ReactiveWebServerFactoryAutoConfigurationTests.java

@@ -40,34 +40,31 @@ import static org.assertj.core.api.Assertions.assertThat;
  */
 public class ReactiveWebServerFactoryAutoConfigurationTests {
 
-	private ReactiveWebApplicationContextRunner contextRunner =
+	private ReactiveWebApplicationContextRunner contextRunner = new ReactiveWebApplicationContextRunner(
-			new ReactiveWebApplicationContextRunner(AnnotationConfigReactiveWebServerApplicationContext::new)
+			AnnotationConfigReactiveWebServerApplicationContext::new)
-					.withConfiguration(AutoConfigurations.of(ReactiveWebServerFactoryAutoConfiguration.class));
+					.withConfiguration(AutoConfigurations
+							.of(ReactiveWebServerFactoryAutoConfiguration.class));
 
 	@Test
 	public void createFromConfigClass() {
-		this.contextRunner
+		this.contextRunner.withUserConfiguration(MockWebServerAutoConfiguration.class,
-				.withUserConfiguration(MockWebServerAutoConfiguration.class,
+				HttpHandlerConfiguration.class).run((context) -> {
-						HttpHandlerConfiguration.class)
-				.run(context -> {
 					assertThat(context.getBeansOfType(ReactiveWebServerFactory.class))
 							.hasSize(1);
 					assertThat(context.getBeansOfType(WebServerFactoryCustomizer.class))
 							.hasSize(1);
-					assertThat(context.getBeansOfType(ReactiveWebServerFactoryCustomizer.class))
+					assertThat(context
-							.hasSize(1);
+							.getBeansOfType(ReactiveWebServerFactoryCustomizer.class))
+									.hasSize(1);
 				});
 	}
 
 	@Test
 	public void missingHttpHandler() {
-		this.contextRunner
+		this.contextRunner.withUserConfiguration(MockWebServerAutoConfiguration.class)
-				.withUserConfiguration(MockWebServerAutoConfiguration.class)
+				.run((context) -> assertThat(context.getStartupFailure())
-				.run(context -> {
+						.isInstanceOf(ApplicationContextException.class)
-					assertThat(context.getStartupFailure())
+						.hasMessageContaining("missing HttpHandler bean"));
-							.isInstanceOf(ApplicationContextException.class)
-							.hasMessageContaining("missing HttpHandler bean");
-				});
 	}
 
 	@Test
@@ -75,34 +72,27 @@ public class ReactiveWebServerFactoryAutoConfigurationTests {
 		this.contextRunner
 				.withUserConfiguration(MockWebServerAutoConfiguration.class,
 						HttpHandlerConfiguration.class, TooManyHttpHandlers.class)
-				.run(context -> {
+				.run((context) -> assertThat(context.getStartupFailure())
-					assertThat(context.getStartupFailure())
+						.isInstanceOf(ApplicationContextException.class)
-							.isInstanceOf(ApplicationContextException.class)
+						.hasMessageContaining("multiple HttpHandler beans : "
-							.hasMessageContaining("multiple HttpHandler beans : " +
+								+ "httpHandler,additionalHttpHandler"));
-									"httpHandler,additionalHttpHandler");
-				});
 	}
 
 	@Test
 	public void customizeReactiveWebServer() {
-		this.contextRunner
+		this.contextRunner.withUserConfiguration(MockWebServerAutoConfiguration.class,
-				.withUserConfiguration(MockWebServerAutoConfiguration.class,
+				HttpHandlerConfiguration.class, ReactiveWebServerCustomization.class)
-						HttpHandlerConfiguration.class, ReactiveWebServerCustomization.class)
+				.run((context) -> assertThat(
-				.run(context -> {
+						context.getBean(MockReactiveWebServerFactory.class).getPort())
-					assertThat(context.getBean(MockReactiveWebServerFactory.class).getPort())
+								.isEqualTo(9000));
-							.isEqualTo(9000);
-				});
 	}
 
 	@Test
 	public void defaultWebServerIsTomcat() {
 		// Tomcat should be chosen over Netty if the Tomcat library is present.
-		this.contextRunner
+		this.contextRunner.withUserConfiguration(HttpHandlerConfiguration.class).run(
-				.withUserConfiguration(HttpHandlerConfiguration.class)
+				(context) -> assertThat(context.getBean(ReactiveWebServerFactory.class))
-				.run(context -> {
+						.isInstanceOf(TomcatReactiveWebServerFactory.class));
-					assertThat(context.getBean(ReactiveWebServerFactory.class))
-							.isInstanceOf(TomcatReactiveWebServerFactory.class);
-				});
 	}
 
 	@Configuration

spring-boot-project/spring-boot-devtools/src/test/java/org/springframework/boot/devtools/autoconfigure/LocalDevToolsAutoConfigurationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/mock/mockito/DefinitionsParserTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-project/spring-boot/src/test/java/org/springframework/boot/web/servlet/DelegatingFilterProxyRegistrationBeanTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/domain/City.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -74,4 +74,5 @@ public class City implements Serializable {
 	public String toString() {
 		return getName() + "," + getState() + "," + getCountry();
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/domain/Hotel.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -80,4 +80,5 @@ public class Hotel implements Serializable {
 	public String getZip() {
 		return this.zip;
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/domain/Rating.java

@@ -17,5 +17,7 @@
 package sample.data.jpa.domain;
 
 public enum Rating {
+
 	TERRIBLE, POOR, AVERAGE, GOOD, EXCELLENT
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/domain/Review.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -128,4 +128,5 @@ public class Review implements Serializable {
 	public void setDetails(String details) {
 		this.details = details;
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/domain/ReviewDetails.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -75,4 +75,5 @@ public class ReviewDetails implements Serializable {
 	public void setDetails(String details) {
 		this.details = details;
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/domain/TripType.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,5 +17,7 @@
 package sample.data.jpa.domain;
 
 public enum TripType {
+
 	BUSINESS, COUPLES, FAMILY, FRIENDS, SOLO
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/service/CitySearchCriteria.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2013 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -41,4 +41,5 @@ public class CitySearchCriteria implements Serializable {
 	public void setName(String name) {
 		this.name = name;
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/service/CityServiceImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2016 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -75,4 +75,5 @@ class CityServiceImpl implements CityService {
 		Assert.notNull(city, "City must not be null");
 		return this.hotelRepository.findByCity(city, pageable);
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/main/java/sample/data/jpa/service/HotelServiceImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -94,5 +94,7 @@ class HotelServiceImpl implements HotelService {
 			Long count = this.ratingCount.get(rating);
 			return count == null ? 0 : count;
 		}
+
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/test/java/sample/data/jpa/service/CityRepositoryIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -41,8 +41,8 @@ public class CityRepositoryIntegrationTests {
 
 	@Test
 	public void findsFirstPageOfCities() {
-
 		Page<City> cities = this.repository.findAll(PageRequest.of(0, 10));
 		assertThat(cities.getTotalElements()).isGreaterThan(20L);
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-jpa/src/test/java/sample/data/jpa/service/HotelRepositoryIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -45,6 +45,7 @@ public class HotelRepositoryIntegrationTests {
 
 	@Autowired
 	CityRepository cityRepository;
+
 	@Autowired
 	HotelRepository repository;
 
@@ -53,16 +54,15 @@ public class HotelRepositoryIntegrationTests {
 		City city = this.cityRepository
 				.findAll(PageRequest.of(0, 1, Direction.ASC, "name")).getContent().get(0);
 		assertThat(city.getName()).isEqualTo("Atlanta");
-
 		Page<HotelSummary> hotels = this.repository.findByCity(city,
 				PageRequest.of(0, 10, Direction.ASC, "name"));
 		Hotel hotel = this.repository.findByCityAndName(city,
 				hotels.getContent().get(0).getName());
 		assertThat(hotel.getName()).isEqualTo("Doubletree");
-
 		List<RatingCount> counts = this.repository.findRatingCounts(hotel);
 		assertThat(counts).hasSize(1);
 		assertThat(counts.get(0).getRating()).isEqualTo(Rating.AVERAGE);
 		assertThat(counts.get(0).getCount()).isGreaterThan(1L);
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-rest/src/main/java/sample/data/rest/domain/City.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -74,4 +74,5 @@ public class City implements Serializable {
 	public String toString() {
 		return getName() + "," + getState() + "," + getCountry();
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-rest/src/main/java/sample/data/rest/domain/Hotel.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -74,4 +74,5 @@ public class Hotel implements Serializable {
 	public String getZip() {
 		return this.zip;
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-rest/src/main/java/sample/data/rest/service/CitySearchCriteria.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2015 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -41,4 +41,5 @@ public class CitySearchCriteria implements Serializable {
 	public void setName(String name) {
 		this.name = name;
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-rest/src/test/java/sample/data/rest/SampleDataRestApplicationTests.java

@@ -58,14 +58,12 @@ public class SampleDataRestApplicationTests {
 
 	@Test
 	public void testHome() throws Exception {
-
 		this.mvc.perform(get("/api")).andExpect(status().isOk())
 				.andExpect(content().string(containsString("hotels")));
 	}
 
 	@Test
 	public void findByNameAndCountry() throws Exception {
-
 		this.mvc.perform(get(
 				"/api/cities/search/findByNameAndCountryAllIgnoringCase?name=Melbourne&country=Australia"))
 				.andExpect(status().isOk())
@@ -75,10 +73,10 @@ public class SampleDataRestApplicationTests {
 
 	@Test
 	public void findByContaining() throws Exception {
-
 		this.mvc.perform(get(
 				"/api/cities/search/findByNameContainingAndCountryContainingAllIgnoringCase?name=&country=UK"))
 				.andExpect(status().isOk())
 				.andExpect(jsonPath("_embedded.cities", hasSize(3)));
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-rest/src/test/java/sample/data/rest/service/CityRepositoryIntegrationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2017 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -43,7 +43,6 @@ public class CityRepositoryIntegrationTests {
 
 	@Test
 	public void findsFirstPageOfCities() {
-
 		Page<City> cities = this.repository.findAll(PageRequest.of(0, 10));
 		assertThat(cities.getTotalElements()).isGreaterThan(20L);
 	}
@@ -63,4 +62,5 @@ public class CityRepositoryIntegrationTests {
 						PageRequest.of(0, 10));
 		assertThat(cities.getTotalElements()).isEqualTo(3L);
 	}
+
 }

spring-boot-samples/spring-boot-sample-data-solr/src/test/java/sample/data/solr/SampleSolrApplicationTests.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2012-2016 the original author or authors.
+ * Copyright 2012-2018 the original author or authors.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -31,7 +31,6 @@ public class SampleSolrApplicationTests {
 
 	@Test
 	public void testDefaultSettings() throws Exception {
-
 		try {
 			SampleSolrApplication.main(new String[0]);
 		}
@@ -44,9 +43,8 @@ public class SampleSolrApplicationTests {
 		assertThat(output).contains("name=Sony Playstation");
 	}
 
+	@SuppressWarnings("serial")
 	private boolean serverNotRunning(IllegalStateException ex) {
-
-		@SuppressWarnings("serial")
 		NestedCheckedException nested = new NestedCheckedException("failed", ex) {
 		};
 		Throwable root = nested.getRootCause();