Merge branch '2.1.x'

Closes gh-18882
pull/18883/head
Andy Wilkinson 5 years ago
commit ce01f7f150

@ -424,7 +424,7 @@ public abstract class EndpointDiscoverer<E extends ExposableEndpoint<O>, O exten
} }
private Class<?> getFilter(Class<?> type) { private Class<?> getFilter(Class<?> type) {
return MergedAnnotations.from(type).get(FilteredEndpoint.class) return MergedAnnotations.from(type, SearchStrategy.TYPE_HIERARCHY).get(FilteredEndpoint.class)
.getValue(MergedAnnotation.VALUE, Class.class).orElse(null); .getValue(MergedAnnotation.VALUE, Class.class).orElse(null);
} }

@ -209,7 +209,8 @@ class EndpointDiscovererTests {
load(SpecializedEndpointsConfiguration.class, (context) -> { load(SpecializedEndpointsConfiguration.class, (context) -> {
SpecializedEndpointDiscoverer discoverer = new SpecializedEndpointDiscoverer(context); SpecializedEndpointDiscoverer discoverer = new SpecializedEndpointDiscoverer(context);
Map<EndpointId, SpecializedExposableEndpoint> endpoints = mapEndpoints(discoverer.getEndpoints()); Map<EndpointId, SpecializedExposableEndpoint> endpoints = mapEndpoints(discoverer.getEndpoints());
assertThat(endpoints).containsOnlyKeys(EndpointId.of("test"), EndpointId.of("specialized")); assertThat(endpoints).containsOnlyKeys(EndpointId.of("test"), EndpointId.of("specialized"),
EndpointId.of("specialized-superclass"));
}); });
} }
@ -252,7 +253,7 @@ class EndpointDiscovererTests {
load(SpecializedEndpointsConfiguration.class, (context) -> { load(SpecializedEndpointsConfiguration.class, (context) -> {
EndpointFilter<SpecializedExposableEndpoint> filter = (endpoint) -> { EndpointFilter<SpecializedExposableEndpoint> filter = (endpoint) -> {
EndpointId id = endpoint.getEndpointId(); EndpointId id = endpoint.getEndpointId();
return !id.equals(EndpointId.of("specialized")); return !id.equals(EndpointId.of("specialized")) && !id.equals(EndpointId.of("specialized-superclass"));
}; };
SpecializedEndpointDiscoverer discoverer = new SpecializedEndpointDiscoverer(context, SpecializedEndpointDiscoverer discoverer = new SpecializedEndpointDiscoverer(context,
Collections.singleton(filter)); Collections.singleton(filter));
@ -401,7 +402,8 @@ class EndpointDiscovererTests {
} }
@Import({ TestEndpoint.class, SpecializedTestEndpoint.class, SpecializedExtension.class }) @Import({ TestEndpoint.class, SpecializedTestEndpoint.class, SpecializedSuperclassTestEndpoint.class,
SpecializedExtension.class })
static class SpecializedEndpointsConfiguration { static class SpecializedEndpointsConfiguration {
} }
@ -494,6 +496,20 @@ class EndpointDiscovererTests {
} }
@SpecializedEndpoint(id = "specialized-superclass")
static class AbstractFilteredEndpoint {
}
static class SpecializedSuperclassTestEndpoint extends AbstractFilteredEndpoint {
@ReadOperation
public Object getAll() {
return null;
}
}
static class SubSpecializedTestEndpoint extends SpecializedTestEndpoint { static class SubSpecializedTestEndpoint extends SpecializedTestEndpoint {
@ReadOperation @ReadOperation

Loading…
Cancel
Save