Align with breaking API changes in RedisCacheManager

See gh-9734
pull/9771/head
Mark Paluch 7 years ago committed by Stephane Nicoll
parent 5416eac620
commit d22cd0cc9e

@ -1,5 +1,5 @@
/* /*
* Copyright 2012-2016 the original author or authors. * Copyright 2012-2017 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -16,6 +16,7 @@
package org.springframework.boot.autoconfigure.cache; package org.springframework.boot.autoconfigure.cache;
import java.util.LinkedHashSet;
import java.util.List; import java.util.List;
import org.springframework.boot.autoconfigure.AutoConfigureAfter; import org.springframework.boot.autoconfigure.AutoConfigureAfter;
@ -27,17 +28,19 @@ import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Conditional; import org.springframework.context.annotation.Conditional;
import org.springframework.context.annotation.Configuration; import org.springframework.context.annotation.Configuration;
import org.springframework.data.redis.cache.RedisCacheManager; import org.springframework.data.redis.cache.RedisCacheManager;
import org.springframework.data.redis.core.RedisTemplate; import org.springframework.data.redis.cache.RedisCacheManager.RedisCacheManagerBuilder;
import org.springframework.data.redis.connection.RedisConnectionFactory;
/** /**
* Redis cache configuration. * Redis cache configuration.
* *
* @author Stephane Nicoll * @author Stephane Nicoll
* @author Mark Paluch
* @since 1.3.0 * @since 1.3.0
*/ */
@Configuration @Configuration
@AutoConfigureAfter(RedisAutoConfiguration.class) @AutoConfigureAfter(RedisAutoConfiguration.class)
@ConditionalOnBean(RedisTemplate.class) @ConditionalOnBean(RedisConnectionFactory.class)
@ConditionalOnMissingBean(CacheManager.class) @ConditionalOnMissingBean(CacheManager.class)
@Conditional(CacheCondition.class) @Conditional(CacheCondition.class)
class RedisCacheConfiguration { class RedisCacheConfiguration {
@ -53,14 +56,14 @@ class RedisCacheConfiguration {
} }
@Bean @Bean
public RedisCacheManager cacheManager(RedisTemplate<Object, Object> redisTemplate) { public RedisCacheManager cacheManager(RedisConnectionFactory redisConnectionFactory) {
RedisCacheManager cacheManager = new RedisCacheManager(redisTemplate);
cacheManager.setUsePrefix(true); RedisCacheManagerBuilder builder = RedisCacheManager.builder(redisConnectionFactory);
List<String> cacheNames = this.cacheProperties.getCacheNames(); List<String> cacheNames = this.cacheProperties.getCacheNames();
if (!cacheNames.isEmpty()) { if (!cacheNames.isEmpty()) {
cacheManager.setCacheNames(cacheNames); builder.initialCacheNames(new LinkedHashSet<>(cacheNames));
} }
return this.customizerInvoker.customize(cacheManager); return this.customizerInvoker.customize(builder.build());
} }
} }

@ -79,7 +79,7 @@ import org.springframework.context.annotation.Import;
import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.ClassPathResource;
import org.springframework.core.io.Resource; import org.springframework.core.io.Resource;
import org.springframework.data.redis.cache.RedisCacheManager; import org.springframework.data.redis.cache.RedisCacheManager;
import org.springframework.data.redis.core.RedisTemplate; import org.springframework.data.redis.connection.RedisConnectionFactory;
import static org.assertj.core.api.Assertions.assertThat; import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.BDDMockito.given; import static org.mockito.BDDMockito.given;
@ -92,6 +92,7 @@ import static org.mockito.Mockito.verify;
* *
* @author Stephane Nicoll * @author Stephane Nicoll
* @author Eddú Meléndez * @author Eddú Meléndez
* @author Mark Paluch
*/ */
@RunWith(ModifiedClassPathRunner.class) @RunWith(ModifiedClassPathRunner.class)
@ClassPathExclusions("hazelcast-client-*.jar") @ClassPathExclusions("hazelcast-client-*.jar")
@ -282,8 +283,9 @@ public class CacheAutoConfigurationTests {
RedisCacheManager cacheManager = validateCacheManager(context, RedisCacheManager cacheManager = validateCacheManager(context,
RedisCacheManager.class); RedisCacheManager.class);
assertThat(cacheManager.getCacheNames()).isEmpty(); assertThat(cacheManager.getCacheNames()).isEmpty();
assertThat((Boolean) new DirectFieldAccessor(cacheManager) org.springframework.data.redis.cache.RedisCacheConfiguration configuration = (org.springframework.data.redis.cache.RedisCacheConfiguration) new DirectFieldAccessor(
.getPropertyValue("usePrefix")).isTrue(); cacheManager).getPropertyValue("defaultCacheConfig");
assertThat(configuration.usePrefix()).isTrue();
}); });
} }
@ -892,8 +894,8 @@ public class CacheAutoConfigurationTests {
static class RedisCacheConfiguration { static class RedisCacheConfiguration {
@Bean @Bean
public RedisTemplate<?, ?> redisTemplate() { public RedisConnectionFactory redisConnectionFactory() {
return mock(RedisTemplate.class); return mock(RedisConnectionFactory.class);
} }
} }

Loading…
Cancel
Save