Use static-locations properties to locate favicon

Closes gh-5751
pull/5808/merge
Venil Noronha 9 years ago committed by Stephane Nicoll
parent 247685e992
commit d5554e0aa1

@ -33,6 +33,7 @@ import org.springframework.core.io.ResourceLoader;
* @author Phillip Webb * @author Phillip Webb
* @author Brian Clozel * @author Brian Clozel
* @author Dave Syer * @author Dave Syer
* @author Venil Noronha
* @since 1.1.0 * @since 1.1.0
*/ */
@ConfigurationProperties(prefix = "spring.resources", ignoreUnknownFields = false) @ConfigurationProperties(prefix = "spring.resources", ignoreUnknownFields = false)
@ -117,10 +118,9 @@ public class ResourceProperties implements ResourceLoaderAware {
} }
List<Resource> getFaviconLocations() { List<Resource> getFaviconLocations() {
List<Resource> locations = new ArrayList<Resource>( List<Resource> locations = new ArrayList<Resource>(staticLocations.length + 1);
CLASSPATH_RESOURCE_LOCATIONS.length + 1);
if (this.resourceLoader != null) { if (this.resourceLoader != null) {
for (String location : CLASSPATH_RESOURCE_LOCATIONS) { for (String location : staticLocations) {
locations.add(this.resourceLoader.getResource(location)); locations.add(this.resourceLoader.getResource(location));
} }
} }

@ -412,7 +412,7 @@ public class WebMvcAutoConfigurationTests {
assertThat(this.context.getBeansOfType(SimpleUrlHandlerMapping.class) assertThat(this.context.getBeansOfType(SimpleUrlHandlerMapping.class)
.get("faviconHandlerMapping"), is(notNullValue())); .get("faviconHandlerMapping"), is(notNullValue()));
Map<String, List<Resource>> mappingLocations = getFaviconMappingLocations(); Map<String, List<Resource>> mappingLocations = getFaviconMappingLocations();
assertThat(mappingLocations.get("/**/favicon.ico").size(), equalTo(5)); assertThat(mappingLocations.get("/**/favicon.ico").size(), equalTo(6));
} }
@Test @Test

Loading…
Cancel
Save